Repository navigation
fix: repair assignment details and competition video preparation - #45
Merged
Merged
Conversation
…_detail get_assignment_detail returns the assignment as to_jsonb(row), so its keys are snake_case table columns, while the client schema expects camelCase. Every agreement screen failed with "Contract not found" against the hosted database, blocking milestones, submission and approval. Normalize the network payload through mapAssignmentRow before validation; cached and camelCase payloads are unchanged. Adds a regression test using the real RPC shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Isolated Remotion/FFmpeg pipeline (video-production/) that renders the 8-minute DO WELL competition film from real Android recordings of the hosted app: narration script and local Kokoro TTS generation, original procedural score with narration ducking, ADB capture and edit tooling, timeline preparation, resumable rendering and automated QA. Media, models, recordings and exports stay local (gitignored). Includes the labor-market research notes and session handoff updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93082f0e07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DanielHC16
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix real assignment-detail snake_case payloads and add the isolated competition-film workspace. Repair subtitle preparation on fresh checkout, minimum-length draft timelines, mobile/video typecheck isolation, and the six compatible SDK patch mismatches exposed by Expo Doctor.
Related issue
Review thread resolved. M03A #4 closed after unfinished hosted/device acceptance transferred to #46; this PR does not complete that acceptance.
Validation
Preparation regressions failed first (ENOENT;426s timeline bounds), then passed. Focused2 suites/26 tests passed; independent re-review LGTM. At head652e331 remote CI41474062126 is fully green: app format/lint/typecheck,111 suites/693 tests, Doctor, Android export; database migrations/policies/types; GitGuardian. Combined upcoming demo-readiness working tree also passed114 suites/713 tests and Android export.
Security and cost
Explicit staging/secret scan; credentials/models/media/APKs/signing material remain ignored. Existing RPC schema/identity validation retained. No schema/RLS/permission/hosted provisioning/billing change. PHP0/USD0.
Screenshots and limits
Prior capture provenance is in video-production/CHECKPOINT.md. No new video export QA or full device acceptance claim. Missing Settings/Admin integration and accurate demo/APK guides are addressed in a separate #47 follow-up. Owner authorized merge on2 November.