Skip to content

fix: caff node batcher addr monitor test#142

Open
varun-doshi wants to merge 1 commit intointegrationfrom
fix-batcher-addr
Open

fix: caff node batcher addr monitor test#142
varun-doshi wants to merge 1 commit intointegrationfrom
fix-batcher-addr

Conversation

@varun-doshi
Copy link
Copy Markdown

Testing on CI since local compilations are giving memory out of bound errors

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces changes to facilitate debugging and fixing the caff-node-batcher-addr-monitor test, which is currently experiencing issues, potentially due to memory out-of-bound errors during local compilation. It updates the default Espresso Nitro node Docker image to a version containing a targeted fix and adjusts the regression test suite to focus on the problematic test by temporarily excluding other related tests. The primary goal is to enable successful execution of the caff-node-batcher-addr-monitor test on CI.

Highlights

  • Dependency Update: Updated the default Espresso Nitro node Docker image to a version (vd-fix-batcher-test) specifically aimed at addressing batcher-related issues.
  • Test Suite Adjustment: Modified the regression test suite to temporarily exclude several batcher-related and caff-node tests, likely to isolate the caff-node-batcher-addr-monitor test for focused debugging and validation.
  • Targeted Fix: The pull request aims to address issues with the caff-node-batcher-addr-monitor test, as indicated by the updated dependency and the selective exclusion of other tests, to enable its successful execution on CI.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be set up for testing a fix on CI. It enables the caff-node-batcher-addr-monitor.bash test, while disabling many other regression tests, and points to a development-specific Docker image (vd-fix-batcher-test). While these changes are understandable for debugging purposes, they should be reverted before merging into the main branch to ensure all tests are active and a stable Docker image is used.

DEFAULT_TOKEN_BRIDGE_VERSION="v1.2.2"

ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468
ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:vd-fix-batcher-test
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The ESPRESSO_DEFAULT_VERSION is being set to a development-specific Docker image tag (vd-fix-batcher-test). This must be reverted to a stable, released version before merging. Using development tags in the main branch can lead to instability and makes rollbacks difficult.

ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468

Comment on lines +10 to +18
! -name 'batcher-e2e.bash' \
! -name 'batcher-shutdown.bash' \
! -name 'batcher-resubmission.bash' \
! -name 'batcher-with-malicious-sequencer.bash' \
! -name 'batcher-with-spam-in-hotshot.bash' \
! -name 'caff-node-force-inclusion-test.bash' \
! -name 'caff-node-restart.bash' \
! -name 'caff-node-state-check.bash' \
# ! -name 'caff-node-batcher-addr-monitor.bash' \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These changes appear to be for temporary debugging on CI. You're disabling many regression tests while enabling caff-node-batcher-addr-monitor.bash. Before merging, please remove all these temporary changes. To enable the test, you can simply remove its exclusion line entirely, which is what the suggested change does.

@varun-doshi varun-doshi force-pushed the fix-batcher-addr branch 3 times, most recently from f105a39 to 11882ff Compare March 18, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant