fix: caff node batcher addr monitor test#142
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces changes to facilitate debugging and fixing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be set up for testing a fix on CI. It enables the caff-node-batcher-addr-monitor.bash test, while disabling many other regression tests, and points to a development-specific Docker image (vd-fix-batcher-test). While these changes are understandable for debugging purposes, they should be reverted before merging into the main branch to ensure all tests are active and a stable Docker image is used.
| DEFAULT_TOKEN_BRIDGE_VERSION="v1.2.2" | ||
|
|
||
| ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468 | ||
| ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:vd-fix-batcher-test |
There was a problem hiding this comment.
The ESPRESSO_DEFAULT_VERSION is being set to a development-specific Docker image tag (vd-fix-batcher-test). This must be reverted to a stable, released version before merging. Using development tags in the main branch can lead to instability and makes rollbacks difficult.
ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468
regression-test.bash
Outdated
| ! -name 'batcher-e2e.bash' \ | ||
| ! -name 'batcher-shutdown.bash' \ | ||
| ! -name 'batcher-resubmission.bash' \ | ||
| ! -name 'batcher-with-malicious-sequencer.bash' \ | ||
| ! -name 'batcher-with-spam-in-hotshot.bash' \ | ||
| ! -name 'caff-node-force-inclusion-test.bash' \ | ||
| ! -name 'caff-node-restart.bash' \ | ||
| ! -name 'caff-node-state-check.bash' \ | ||
| # ! -name 'caff-node-batcher-addr-monitor.bash' \ |
There was a problem hiding this comment.
These changes appear to be for temporary debugging on CI. You're disabling many regression tests while enabling caff-node-batcher-addr-monitor.bash. Before merging, please remove all these temporary changes. To enable the test, you can simply remove its exclusion line entirely, which is what the suggested change does.
f105a39 to
11882ff
Compare
11882ff to
fbafc5e
Compare
Testing on CI since local compilations are giving memory out of bound errors