Skip to content

fix: caff node batcher addr monitor test #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varun-doshi wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

fix: caff node batcher addr monitor test #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions regression-test.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ cd "$(dirname "$0")"
cd regression-tests
scripts=$(find . -maxdepth 1 -name '*.bash' \
! -name 'common.bash' \
! -name 'caff-node-batcher-addr-monitor.bash' \
| sort)

for script in $scripts; do
Expand All @@ -31,4 +30,4 @@ done

cd ..
echo "All regression tests completed successfully!"
docker compose down --remove-orphans
docker compose down --remove-orphans
2 changes: 1 addition & 1 deletion test-node.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ BLOCKSCOUT_VERSION=offchainlabs/blockscout:v1.1.0-0e716c8
DEFAULT_NITRO_CONTRACTS_VERSION="v3.1.0"
DEFAULT_TOKEN_BRIDGE_VERSION="v1.2.2"

ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468
ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:vd-fix-batcher-test
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The ESPRESSO_DEFAULT_VERSION is being set to a development-specific Docker image tag (vd-fix-batcher-test). This must be reverted to a stable, released version before merging. Using development tags in the main branch can lead to instability and makes rollbacks difficult.

ESPRESSO_DEFAULT_VERSION=ghcr.io/espressosystems/nitro-espresso-integration/nitro-node:v3.9.2-e8d0468

: ${ESPRESSO_VERSION:=$ESPRESSO_DEFAULT_VERSION}

# Set default versions if not overriden by provided env vars
Expand Down
Loading