Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/flu-858-app-lifecycle-controller #1440 +/- ##
=========================================================================
- Coverage 44.59% 44.58% -0.02%
=========================================================================
Files 423 423
Lines 31506 31495 -11
=========================================================================
- Hits 14051 14041 -10
+ Misses 17455 17454 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
renefloor
added this pull request to stack #1442
October 9, 2026 06:12
Call, its session and its RTC manager depend on CallHost, the members of the client they use: the client state, the current user, the options, telemetry, the push manager, audio processing and the accept hook. StreamVideo implements it, and tests build calls on a MockCallHost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
renefloor
force-pushed
the
feat/flu-852-call-host
branch
from
October 9, 2026 12:27
c40daa4 to
7ff78bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FLU-852
Part of FLU-859 · 25/26, stacked on #1439
What changed
CallHost(lib/src/call/call_host.dart, exported) is the part of the client that aCalluses, andStreamVideoimplements it.Callkeeps it as_hostinstead of_streamVideo.Members:
state,currentUser,options,apiKey,pushNotificationManager;deviceSupportsAdvancedAudioProcessing();@internal:clientEventReporter,webrtcInitializationCompleter,prepareToAccept(call),isAudioProcessorConfigured(),setAudioProcessingEnabled(bool).What got narrower after C1, B3 and C4:
ClientState(C1).prepareToAccept(B3).Callnow reaches the client at 43 sites through 9 members, down from 45 sites across 25 members onv2. The session usesapiKeyandwebrtcInitializationCompleteron top of those.Where
CallHostreplacesStreamVideo:Calland its factories. The factories keep thestreamVideo:parameter name, so passing aStreamVideostill compiles.CallSessionandCallSessionFactory, whichCallhands the host to.RtcManagerandRtcManagerFactory, for the same reason.Decisions to check
CallHostis public, with@internalmembers.Call's public factories take it, so it has to be exported. Its@internalmembers stay off the public API. It is aninterface class: it can be implemented but not extended.Callonly, butCallpasses its host on to them. Leaving them onStreamVideowould keep the concrete type inCall. They usecurrentUser,apiKey,options,clientEventReporterandwebrtcInitializationCompleter, all onCallHost.prepareToAcceptis on the host, notringing. That keeps a fake host from needing aRingingCallCoordinator.StreamVideoforwards it toringing.prepareToAccept.streamVideo:parameter keeps its name. Renaming it tohost:would break everyCall(...)andCall.fromRinging(...)caller for no gain; the type is what matters.Tests
MockStreamVideoinstream_video'stest_helpers.dartis nowMockCallHost. It keeps the telemetry no-op, andprepareToAcceptreturnsnull.setupMockStreamVideois nowsetupMockCallHost. It no longer stubsactiveCalls, whichCallstopped reading in B3.stream_video_flutter'sMockStreamVideostay, since they stand in for the client itself.stream_video: 1309 passed;stream_video_push_notification: 67;stream_video_flutterwithout goldens: 729.🤖 Generated with Claude Code