fix(analytics): count rejected recommendations as negative#403
Open
JSONbored wants to merge 1 commit into
Open
fix(analytics): count rejected recommendations as negative#403JSONbored wants to merge 1 commit into
JSONbored wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 45ebfe5 | Commit Preview URL Branch Preview URL |
Jun 05 2026, 08:18 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rejectedoutcomes (changes-requested PRs) from negative accounting, causing totals, rates, trends, and role surfaces to under-count negative outcomes.Description
rejectedas a negative outcome by adding it toNEGATIVE_STATESand expanding theRecommendationQualityFailureCategoryunion insrc/services/recommendation-quality-report.ts.rejectedfailure category labeled "Changes requested" so rejected outcomes surface in failure breakdowns insrc/services/recommendation-quality-report.ts.test/unit/recommendation-quality-report.test.tsto prevent regression and validate totals, role surfaces, trends, and failure categories.src/services/recommendation-quality-report.ts,test/unit/recommendation-quality-report.test.ts.Testing
npx vitest run test/unit/recommendation-quality-report.test.ts --reporter=dotand all tests passed (file-level suite passed).npm run typecheckand the TypeScript check completed successfully.Codex Task