Skip to content

fix(analytics): count rejected recommendations as negative #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 5, 2026
Merged

fix(analytics): count rejected recommendations as negative #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/services/recommendation-quality-report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export type RecommendationQualityTrendBucket = RecommendationQualityTotals & {
};

export type RecommendationQualityFailureCategory = {
category: "closed_without_merge" | "stale" | "ignored" | "low_confidence" | "maintainer_lane";
category: "closed_without_merge" | "rejected" | "stale" | "ignored" | "low_confidence" | "maintainer_lane";
label: string;
count: number;
detail: string;
Expand Down Expand Up @@ -59,7 +59,7 @@ export type RecommendationQualityReport = {

const ROLE_ORDER: RecommendationQualityRole[] = ["miner", "maintainer", "owner", "operator"];
const POSITIVE_STATES: AgentRecommendationOutcomeState[] = ["accepted", "merged", "improved"];
const NEGATIVE_STATES: AgentRecommendationOutcomeState[] = ["closed", "stale", "ignored"];
const NEGATIVE_STATES: AgentRecommendationOutcomeState[] = ["closed", "rejected", "stale", "ignored"];

export async function buildRecommendationQualityReport(
env: Env,
Expand Down Expand Up @@ -167,6 +167,12 @@ function failureCategoryRows(outcomes: AgentRecommendationOutcomeRecord[]): Reco
count: outcomes.filter((outcome) => outcome.outcomeState === "closed").length,
detail: "Recommended work reached a closed terminal state without a merge signal.",
},
{
category: "rejected",
label: "Changes requested",
count: outcomes.filter((outcome) => outcome.outcomeState === "rejected").length,
detail: "Recommended PR work received a changes-requested review signal.",
},
{
category: "stale",
label: "Stale follow-through",
Expand Down
38 changes: 38 additions & 0 deletions test/unit/recommendation-quality-report.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,44 @@ describe("recommendation quality report", () => {
expect(JSON.stringify(report)).not.toMatch(FORBIDDEN_REPORT_TERMS);
});

it("counts rejected outcomes as negative recommendations", () => {
const rejectedOnly = buildRecommendationQualityReportFromOutcomes(
[outcome("rejected", "rejected", { actionType: "monitor_existing_pr", repo: "owner/rejected", updatedAt: "2026-05-30T00:00:00.000Z" })],
{ generatedAt: "2026-06-01T00:00:00.000Z", windowDays: 14 },
);

expect(rejectedOnly).toMatchObject({
empty: false,
sparse: true,
totals: { total: 1, positive: 0, negative: 1, positiveRate: 0 },
roleSurfaces: [
expect.objectContaining({
role: "maintainer",
total: 1,
positive: 0,
negative: 1,
topRepos: [expect.objectContaining({ repoFullName: "owner/rejected", signal: "negative" })],
}),
],
failureCategories: [expect.objectContaining({ category: "rejected", count: 1 })],
});
expect(rejectedOnly.trends.some((bucket) => bucket.total === 1 && bucket.negative === 1)).toBe(true);

const mixed = buildRecommendationQualityReportFromOutcomes(
[
outcome("accepted", "accepted", { repo: "owner/mixed", updatedAt: "2026-05-29T00:00:00.000Z" }),
outcome("mixed-rejected", "rejected", { repo: "owner/mixed", updatedAt: "2026-05-30T00:00:00.000Z" }),
outcome("closed", "closed", { repo: "owner/mixed", updatedAt: "2026-05-31T00:00:00.000Z" }),
],
{ generatedAt: "2026-06-01T00:00:00.000Z", windowDays: 14 },
);

expect(mixed).toMatchObject({
totals: { total: 3, positive: 1, negative: 2, positiveRate: 0.333 },
roleSurfaces: [expect.objectContaining({ role: "miner", total: 3, positive: 1, negative: 2 })],
});
});

it("reports empty and sparse private states deterministically", () => {
const empty = buildRecommendationQualityReportFromOutcomes([], { generatedAt: "2026-06-01T00:00:00.000Z", windowDays: 90 });
expect(empty).toMatchObject({
Expand Down