Skip to content

docs(platform): port the git migrations and LavaFlow intake docs from volcano-hosting - #178

Merged
swkeever merged 1 commit into
mainfrom
skeever/port-late-docs-3
Nov 13, 2026
Merged

swkeever merged 1 commit into
mainfrom
skeever/port-late-docs-3

Conversation

@swkeever

Copy link
Copy Markdown
Contributor

Why

Kong/volcano-hosting#3406 and #3412 changed docs/public after #172 ported the previous late change. Kong/volcano-hosting#3404 deletes docs/public, so this carries both over first.

What changed

  • content/platform/projects/git-deploy.md (#3406: volcano git migrations) and content/platform/guides/lavaflow.md (#3412: LavaFlow intake checks): the docs/public diff from volcano-hosting e03f56b to 10c09e6, applied as is.

Testing

  • pnpm lint:docs content and pnpm check:links: pass.

🤖 Generated with Claude Code

… volcano-hosting

Ports the docs/public changes in Kong/volcano-hosting#3406 and #3412.
Copilot AI balanced review requested due to automatic review settings November 13, 2026 18:14
@swkeever
swkeever enabled auto-merge November 13, 2026 18:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Git migration and LavaFlow documentation updates.

No open issues 🎉

What changed in this PR

Carries over the latest Git migration and LavaFlow documentation from volcano-hosting, following #172, before the upstream docs/public directory is removed.

Changes:

  • Documents CLI commands for enabling and disabling Git migrations, skipping confirmation, and checking status.
  • Clarifies how LavaFlow hides paths containing secrets or control characters and redacts associated questions and explanations.
File Description
content/​platform/​projects/​git-deploy.md Adds CLI migration controls alongside existing API instructions.
content/​platform/​guides/​lavaflow.md Updates path-redaction behavior for runs and findings.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed e031cc1. Run log

This is a docs-only port of two volcano-hosting docs/public changes. git-deploy.md now covers turning on apply_migrations with volcano git migrations on|off, and lavaflow.md now says paths with control characters are blanked and that the related hold-reason question and finding explanation are hidden. The risk is low. The new CLI text matches the existing content/cli/git.md, and the one gap found is a field description in lavaflow.md that wasn't updated to match.

⚪ P3

  • content/platform/guides/lavaflow.md:1738 changed_files description still says only a secret path reads ""
  • content/platform/projects/git-deploy.md:763 New CLI paragraph doesn't link the CLI page that documents the command

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

  • Whether the released CLI ships volcano git migrations on|off, so the git-deploy.md text can merge under the release-timing rule.
  • Whether production LavaFlow already blanks control-character paths and hides the related hold-reason questions and finding explanations.
  • Whether the ported text matches the volcano-hosting docs/public diff from e03f56b to 10c09e6 exactly, as the description claims.
  • Confirm production LavaFlow implements the documented filtering of paths, finding explanations, and hold questions before publishing.

Human review: not needed

@swkeever
swkeever added this pull request to the merge queue Nov 13, 2026
```

It asks you to confirm; `--yes` skips the prompt, for CI and agents.
`volcano git migrations off` turns it off, and `volcano git status` shows it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ P3: New CLI paragraph doesn't link the CLI page that documents the command

The added paragraph repeats the confirmation and --yes behavior of volcano git migrations but doesn't link /cli/git. That page's "Applying database migrations on push" section covers the same command, including that the confirmation names the repository and branch and that it fails where migrations aren't available. spec/writing.md says to cross-link rather than repeat. A link such as [volcano git migrations](/cli/git#applying-database-migrations-on-push) would keep the two pages from drifting apart.

Found by claude-opus-5-5

Merged via the queue into main with commit 5024cd6 Nov 13, 2026
19 checks passed
@swkeever
swkeever deleted the skeever/port-late-docs-3 branch November 13, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants