Repository navigation
fix: refuse to provision a group over an account it does not own - #36
Merged
vitormattos merged 1 commit intoNov 14, 2026
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
YvesCesar
force-pushed
the
fix/restrict-subadmin-group-additions
branch
from
November 14, 2026 15:20
0677ca9 to
b902842
Compare
YvesCesar
force-pushed
the
fix/refuse-adopting-foreign-accounts
branch
from
November 14, 2026 15:20
6e063b4 to
90ab1d3
Compare
vitormattos
merged commit Nov 14, 2026
06a2355
into
fix/restrict-subadmin-group-additions
25 of 33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #35.
Purpose
createAdminGroupusesgroupidas both the group ID and the user ID of the group admin. When an account with that ID already existed, it was reused as is: its display name, email and quota were overwritten, it was added to the new group and made its subadmin, while keeping its password and its other groups. An account created in advance with the ID of a future customer therefore became that customer's group admin, still controlled by whoever created it. The same applied to existing admin accounts. The email was also validated only after the group, its quota and the apps job were already created, leaving partial state behind on invalid input.Changes
groupidwithIUserManager::validateUserId.groupidisadmin, or when an account with this ID exists and is not already the subadmin of the group with the same ID, or is an admin or delegated admin. Provisioning an existing group again keeps returning 200.Verification
composer run openapipass locally.groupid=admingets 409 and the admin account is unchanged;