Repository navigation
fix: record the WordPress login link when creating the group admin account - #37
Merged
vitormattos merged 3 commits intoNov 14, 2026
Conversation
This was referenced Nov 14, 2026
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…count Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
YvesCesar
force-pushed
the
fix/refuse-adopting-foreign-accounts
branch
from
November 14, 2026 15:20
6e063b4 to
90ab1d3
Compare
YvesCesar
force-pushed
the
fix/record-wordpress-login-link
branch
from
November 14, 2026 15:20
ace3dd2 to
7c1fa32
Compare
Member
Author
|
@vitormattos fixed 😅 |
vitormattos
approved these changes
Nov 14, 2026
…led-users fix: only enable again the users disabled for billing
vitormattos
merged commit Nov 14, 2026
985f6f9
into
fix/refuse-adopting-foreign-accounts
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #36.
Purpose
The
wordpress_login_backendapp will require an explicit link between a Nextcloud account and a WordPress login before authenticating that account with WordPress credentials. The link is the user preferencewordpress_login_backend/wordpress_login, holding the Nextcloud user ID.Changes
createAdminGroupwrites this preference only when it actually creates the group admin account. It is not written when an existing account is reused, inchange-admin-email, nor for members created by the group admin, which use the Database backend with a Nextcloud password.FalsableReturnStatemententry that Psalm now reports as unused.The refusal to reuse accounts that do not belong to the group (#36) is what makes this preference trustworthy, so this change depends on it. Existing installations need the linking step of
wordpress_login_backendfor accounts created before this version.Verification