Repository navigation
Conversation
…e that fits The typed signature used a fixed 30px font, leaving short names small on the final document. Draw it on a single line, sized to the canvas width minus a small margin and capped at 80% of the canvas height. When the fitted size would fall below the current 30px, keep the existing word-wrapping at 30px. Signed-off-by: no84by <50858621+no84by@users.noreply.github.com>
This was referenced Nov 18, 2026
Author
|
Screenshots (test instance on main 7a8403d vs this branch, light and dark theme): Text tab, short name
Text tab, long name (keeps the existing wrapping)
Text tab, medium name
The script font did not load on the test instance, so both versions render in a serif fallback; the size difference is what this PR changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.












Part of #9048 (signature appearance).
Summary
The typed signature was drawn at a fixed 30px, so short names looked small on the final document. It is now drawn on one line at the largest size that fits the canvas width minus a 6px margin per side, capped at 80% of the canvas height. Long names whose fitted size would fall below 30px keep the current wrapping at 30px. The sizing is a pure helper with unit tests.
Measured with summed Dancing Script advance widths (no kerning), default 350x100 canvas:
At 700x200 the same long name is 35.6px on one line and the short name 160px.
How to test
Open the typed signature dialog. A short name fills most of the canvas height; a long name keeps wrapping as before.
Validation evidence
New helper spec and
TextInput.spec.tspass (32 tests); eslint clean on the changed files.TextInput.spec.ts)UI / Front-end changes
Checklist
AI (if applicable)