Repository navigation
Conversation
A certification (DocMDP) signature has to be the first signature of a document. With DocMDP enabled, the native engine certified every invisible signature, also on a document that was already signed or already certified, which invalidates the earlier signatures' DocMDP semantics. Certify only when the document has no signature yet, for invisible and visible signatures alike. Signed-off-by: no84by <50858621+no84by@users.noreply.github.com>
…nature The JSignPdf parameters are kept on the handler between signatures and new parameters are merged into them. After a certifying signature, the next signature made by the same handler (for example on a document that is already signed) still carried "-cl" and certified again. When DocMDP is enabled, a signature that does not certify now sends "-cl NOT_CERTIFIED", which replaces any earlier level. Signed-off-by: no84by <50858621+no84by@users.noreply.github.com>
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8946 (correct PAdES/DocMDP handling).
Summary
A certification (DocMDP) signature must be the first signature of a document. Two cases certified a document that was already signed:
-cland certified again. When DocMDP is enabled, a signature that does not certify now sends-cl NOT_CERTIFIED, which replaces any earlier level.Two commits, one per engine, each with a regression test.
How to test
Validation evidence
PhpNativeSigningRegressionTest::testInvisibleSignatureDoesNotCertifyASignedDocument,::testLaterSignatureKeepsTheCertificationOfTheFirstSignature(real signatures, checked with the validation service and OpenSSL) andJSignPdfHandlerTest::testCertificationLevelIsNotReusedByTheNextSignature. All three fail onmainand pass with the fix.SignFileService; integration testsPhpNativeSigningRegressionTest,JSignPdfHandlerTest,Pkcs12HandlerTest.API / Back-end changes
composer openapiwhen necessaryChecklist
AI (if applicable)