Repository navigation
fix: refuse accounts named after a WordPress login unless an admin creates them - #31
Merged
vitormattos merged 1 commit intoNov 14, 2026
Conversation
…eates them Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
vitormattos
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Nextcloud lets a sub-admin create accounts with any free uid in their groups. Nothing stopped a sub-admin from creating an account whose uid is the login of an existing WordPress user that is not yet in Nextcloud, taking that name before the real customer is provisioned.
What changed
BeforeUserCreatedListener: when there is a logged in user who is neither an administrator nor a delegated administrator, it refuses to create an account whose uid is exactly a WordPressuser_login.occ, background jobs) and by administrators, which is how Admin Group Manager provisions customers, is not affected.How it was verified
composer run lintandcomposer run test:unitpass locally.Based on #30.