Repository navigation
Conversation
A hung CLI call only showed nextest's generic timeout, with no command name or output, and the gateway log tail started after the stalled test. - The runner exports the per-test limit as OPENSHELL_TEST_TIMEOUT_SECS. testkit caps its CLI, exec, wait and poll timeouts to the time left, so a stuck step fails with its own error. Cleanup keeps its own timeouts. - A CLI command that times out reports its output so far. A command that is slow, exits non-zero, or is still running is reported while the test runs. - The k3s diagnostics collect gateway logs from the run's start time, with a 30 minute fallback, instead of the last 300 lines. Part of #5333. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5450. Review that PR first; this diff is against its branch.
Summary
A hung CLI call in a conformance lane showed only nextest's generic TIMEOUT, with no command name or output, and the gateway log tail began after the stalled test.
OPENSHELL_TEST_TIMEOUT_SECS, from the same constant as the nextest profile and the program's--timeout. testkit caps its CLI, sandbox exec, sandbox wait and poll timeouts to the time left minus 5 s, so a stuck step fails with its own error. Cleanup keeps its own timeouts. Without the variable, nothing is capped.--since-time, written by the runner in the guest), with a 30 minute fallback, keeping the first 64 KiB and last 512 KiB.Related Issue
Part of #5333. Not covered here, so the issue stays open:
junit.xmlis still lost on a run-level timeout; that fits test(runner): follow-ups to running a prebuilt testkit program on runner rows #5416.Testing
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass fortests/testkitandtests/runner.collect-k3s.shwas only syntax-checked (bash -n), and no e2e lane was run.