Repository navigation
Conversation
The field now sits across the top of a rounded box with the + and a round Push button under it, like the Claude app's composer. That settles the old height mismatch between the field and the Push button, and Push takes less room. On iOS the bar is Liquid Glass tinted with the surface, so messages scrolling behind it blur instead of showing through. Android keeps its solid surface bar. The box is a shared partial (composer-box, with send-button) so the commit reply bar can move to it later. body-counter gains a text form of the fold hint for that box, and the Remotes length counter moves into its own partial. Empty slots above the box now take 0.1pt: on iOS an empty one took 10pt of the bar, which showed as a gap once the bar had a backdrop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The composer bar was a bordered box on Liquid Glass tinted at 70%, which
looked heavy, with a hard top edge. Now the field and its row sit straight
on the surface, and a 28pt gradient over the foot of the thread fades it
out above the bar on both platforms. Android gets the same fade, since it
lies over the scroll view rather than relying on a blur. EDGE's gradient
stops have no dark companion, so the stops come from theme('surface') and
the screen draws again on AppearanceChanged.
"folded in feeds" (and the FoldVertical icon before it) is gone from
body-counter, so nothing in the composers says a long commit gets folded.
The countdown near the limit stays.
composer-box takes $lead and $trail partials for the start and end of its
row, in place of $counter, so the commit page can put the drop and a
"post as" avatar there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On iOS the screen runs on under its bottom bar, so a fade lying over the foot of the thread sat under the bar and never showed. The bar now draws it as its first row there, and its rows (composer-rows) have the surface of their own. The bar itself has no background on iOS: mobile-air paints a bar's background colour behind the whole bar, which hid the fade. The strip under the home indicator still shows the surface, from the scroll view's background. Android keeps the fade over the foot of the thread, since its screen stops at the bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picking two photos from the library kept only the last. A photo moved into the draft folder keeps its own time, often years ago, and until the draft holds it nothing does, so keeping the second one pruned the first as long forgotten. The kept file's time is now the time it was picked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On iOS the thread now shows through the bar, blurred, instead of stopping at a solid surface. The bottom-bar carries glass, and a patched mobile-air draws the glass behind the whole bar, under the home indicator too, faded in over the bar's top 28pt so it has no hard edge. The fade row ends at the glass's tint and the rows tint the glass with the surface at 40%, so in dark mode the bar matches the screen. EDGE's glass on an element can't do this: it draws a rim and lenses the content along its top edge, and it stops above the home indicator, where the thread showed through unblurred. Android is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message composer at the bottom of a Remotes thread has the field across the top, growing to five lines, and under it a row with the + (photos, a voice note, Ping) on the left and a round Push button with an up arrow on the right, in your colour. Push is a muted circle while there's nothing to send, and the 1,600+ character count sits beside it.
This fixes Push being shorter than the field on iOS, since they're no longer side by side.
The bar
There's no box, border or hairline. On iOS the bar is Liquid Glass: the thread scrolls on under it and shows through blurred, so the bar is no longer a solid block. The glass fades in over the bar's top 28pt and runs on under the home indicator, so it has no hard top edge. On Android the field and its row sit on the surface as before, with the thread fading out above the bar through a 28pt gradient.
<native:bottom-bar class="glass">(Display::composerBarGlass()) asks mobile-air to draw the glass behind the whole bar. That needs a patched mobile-air (see below). The bar's first row is the fade, a gradient from see-through to the surface at 40%, and the rows under it have the surface at 40% (Display::composerSurface(),ComposerGlassTint). The tint keeps the glass close to the screen's own colour. Without it the glass came out a lighter grey than the screen in dark mode. A fill reaches under the home indicator, so the tint goes there too. The bar column itself still has no background, since mobile-air paints a bar's background colour behind the whole bar.EDGE's gradient stops don't get a dark companion the way
bg-theme-*does, soDisplay::composerFade()builds them fromtheme('surface'), and the screen draws again onAppearanceChanged(theRedrawsOnAppearanceChangetrait). I checked switching light and dark with the thread open.The mobile-air patch behind the glass
EDGE's own
glassclass can't give a soft edge. On the rows it draws Liquid Glass in the element's shape, with a bright rim and some lensing along the top, it can't be faded, and it stops above the home indicator, where the thread showed through unblurred. So the glass comes from a small change to mobile-air'sNativeRootTabsRenderer: when abottom_barcarriesglass, it draws glass behind the bar and through the bottom safe area, masked by a gradient so it fades in over the top 28pt. It's one file, about 50 lines. For now it's only applied in thevendorfolder of the iPhone build, not opened upstream. Without it iOS still works, but the bar is just the 40% tint with nothing blurred behind it.Things I tried first, with screenshots on the idea board:
glasson the rows in place of the surface. The rim and lensing make a hard line at the top, and the strip under the home indicator isn't covered..safeAreaBar. The automatic style draws a hairline. The soft style hardly blurs at the field's height, so a message behind the placeholder stays readable.Shared with the commit page
composer-box(the field over a row of tools and the send button) andsend-buttonare shared partials, which the reply bar on a commit's page uses in #180.composer-boxtakes$leadand$trailpartials for the start and end of its row, in place of$counter: #180 puts the drop and the count in$trail, and the "post as" avatar from #182 fits in$lead.composer-fade,Display::composerBar()andDisplay::fadesInBar()do the fade,Display::composerBarGlass()andcomposerSurface()the glass, andDisplay::ComposerBoxBarHeight,ComposerFadeHeightandcomposerBoxGrowth()give a screen its clearance under the bar.Other changes
body-counter, so the composer sheet no longer says a long commit gets folded. The countdown near the limit stays.Commit::isFoldedInLists()and the preview constants had no other users, so they went too.DraftImages::keep()now touches the kept file. This happens on main too. The commit page's new photo button in Commit screen: photos and preview in the reply bar, drop any time, related commits folded #180 showed it up.h-[0.1]when empty. On iOS an empty row took 10pt of the bar, and EDGE ignores a height of 0. The slots keep their keys and places, so the field doesn't move among its siblings and Android keeps the keyboard.Everything else the composer did is unchanged: keep-focus, mention picking, the + menu, the voice note in the field's place, photos, the reply strip and Push's disabled states.
The text jumping as you type
Simon saw the reply field's text jump on the commit page, with the top line cut in half. It's the same text input here. The cause is in mobile-ui's iOS multiline input, not in the app, and #180 has the details and the upstream fix. Nothing in this PR drives the field's height while you type: PHP only sets
max-lines, which never changes.Gaps that need mobile-air or mobile-ui
.safeAreaInset(NativeRootTabsRenderer) and paint the bar's background colour behind all of it, so a bar can't be partly see-through by itself. That's why the fade is the bar's first row on iOS.TailwindParser::parseGradientStopresolvestheme-*in light only), hence the redraw on an appearance change.l.height > 0inNodeLayoutModifier).Testing
Tested on an iOS 27.0 simulator (iPhone 18 Pro) and an Android 35 emulator against a local API, in light and dark, keyboard up and down: an image scrolled under the bar, a long message growing past five lines, mentions in an org thread (picking one kept the keyboard), and switching appearance with the thread open. On iOS I also typed at the medium and XXL text sizes. There's no Android shot of an empty field with the keyboard up; the long message with the keyboard up covers it. The glass I checked on the iOS simulator in light and dark, keyboard up and down, with photos scrolled under the bar, a long message and mentions. 1,906 tests pass, run serially.
Screenshots
The iOS After shots show the glass. Android is unchanged.
remotes-behind
remotes-keyboard
remotes-long
remotes-long-keyboard
remotes-mentions
🤖 Generated with Claude Code