Skip to content

Hide replies on the Log until asked, open them in place, and line the rail's end dot up with the actions - #179

Draft
simonhamp wants to merge 2 commits into
mainfrom
feat/log-threads
Draft

simonhamp wants to merge 2 commits into
mainfrom
feat/log-threads

Conversation

@simonhamp

@simonhamp simonhamp commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Replies no longer show under commits on the Log. A commit's replies button moves to its own line under the action row and opens the thread in place, ten replies at a time. Replies get the same button, which opens their own replies inline one step in. The rail's end dot now lines up with the action row on every commit, opening and closing a thread animates, a star or pastel pops when you give it, and Quote has a label.

What changed

End dot on the rail. The dot was placed a fixed 20pt above the bottom of the commit's row, which only matched the action row by accident. Two things moved the action row away from it. The row had -my-[6]: iOS takes that space back, but Android's ComposeFlexLayout turns a negative margin into a drawing offset and keeps the space, so the actions sat 6pt lower on Android. And a commit with a thread under it had no bottom padding, so its actions were 13pt lower than on a commit without one. That's why the dot was above the actions on one commit and below on the next.

The dot is now drawn inside the action row itself, as an absolute child at the rail's x (top-[9] -left-[33]), so it's centred on the actions whatever the body, images or Show more state above, on both platforms. The action row lost its vertical negative margins and is a plain 36pt row. The rail's solid line and the dashes down to an open thread still come from the bottom of the row, so they're worked out from the fixed heights under the actions (padding, the replies line) and end 2pt inside the dot's ring, where a pt either way doesn't show. Rows are 6pt taller on iOS than before and 6pt shorter on Android, so both now match.

Replies hidden. The Log no longer draws devnull's reply preview. "N replies" sits on its own 36pt line under the actions, with a chevron that turns down and reads "Hide replies" while the thread is open. It's the same on Profile, Search, Starred and org feeds, since they share the feed partial.

Ten at a time. Opening a thread shows its first ten replies, oldest first, with Show more for the next ten. Client::RepliesPerPage goes from 5 to 10, which the commit page uses too. While testing I found devnull's API ignores limit and always sends up to 50 replies a page (CommitReplyController::index never reads it, on dev-null.sh production as well). So the Log keeps what it was sent and shows ten at a time, and only asks for the next page once they all show. The commit page still shows whatever a page brings, as it did before.

Second-level replies inline. A reply opened in the Log has its own replies button under its actions. Tapping it opens those replies under it, indented 32pt and hung off the dashed line from its avatar, with their own Show more. A reply that deep opens its page from its replies button, as before. Threads are kept by the id of the commit or reply they answer, so nested ones sit in the same $threads. App\Devnull\ThreadRows works out the list rows of an open thread and every line beside them. "Show more" is now a 44pt list row of its own, so it can follow a reply's nested replies. Closing a commit's thread closes the replies opened inside it.

Opening and closing animate. mobile-ui's list can't animate a row coming in or going (see below), so thread rows fade. A newly opened page is drawn see-through and nudged up 8pt, then a frame later drawn as it should be, which EDGE eases to over 220ms with animate-duration. Closing fades the rows out the same way, then takes them out. The chevron turns with the same duration. Only what's beside the rail fades, so the commit's rail running past never blinks.

No jump when a thread opens or closes. The commit's row used to lose the 7pt under its replies line, where the hairline sits, while its thread was open. When the commit's top was off screen, the iPhone's list held the row below still and moved the commit by those 7pt instead, so its photo jumped. The row now keeps that padding with the thread open and only the hairline goes. The first reply takes the 7pt off its own top, so the open thread looks the same.

Star and pastel taps. The web's star-pop grows the star to 1.35, tilts it 12 degrees and springs it back, only when starring. Its pastel button scales the pastel to 1.25 and back. The app does the same: drawn with the animation on, then scaled up, then back with a spring (star) or ease-out (pastel). The animation props come off afterwards, so the rows don't carry an animated node for good.

The steps between frames come from App\Devnull\Beat, an AsyncTask that waits a few milliseconds on a background thread. When it comes back the screen draws the next step. Concerns\PopsReactions and Concerns\ExpandsThreads drive it.

Quote label. Quote reads "Quote" beside its icon, and Reply always has its label now that the replies count isn't in the row.

Upstream gaps

  1. No animated row insertion or height change in native:list. On iOS, NativeUIListRenderer updates its ForEach outside an animation transaction, and on Android ListRenderer adds item(key = row.id) without Modifier.animateItem(). So opened replies take their space at once and the rows below jump, and only their content fades. Animating keyed inserts and removals (and the height change they cause) in mobile-ui would let this slide open properly.
  2. No sequence or on-appear animation in EDGE. animate-duration only eases between two frames, so anything that goes there and back (a pop) or starts from a different value when it appears (a fade-in) needs a PHP round trip per step. Something like appear-opacity / appear-translate-y, or keyframes, would remove the Beat tasks. The first frame also has to carry the animation props already, or iOS adds NodeAnimationModifier and the new value in the same update and nothing animates.
  3. devnull's replies endpoint ignores limit. Not mobile, but worth a dev-null.sh change so the app stops downloading 50 replies to show ten.

Related PRs

How I tested

Against a local API (dev-null.sh production 2ef29e77 plus the picture viewer branch) on port 8191, signed in as local-dev, with seeded commits: one with 14 replies where the first has 12 replies of its own and two others have 3, a short commit with 3 replies (one with an image), an image commit with none, a run of two commits by one author, one-line and long commits.

On an iOS 27.0 simulator and an Android 35 emulator, light and dark, scrolling the Log: closed and open threads, nested replies, Show more at both levels, closing with nested replies open, the end dot on short, long, image and thread commits, starring commits and replies, pastéis on with a pastel given. The recordings below show the fade, the chevron and the star and pastel pops.

php artisan test: 1,901 pass. tests/Feature/Screens/LogThreadTest.php replaces ReplyPreviewTest.php and covers hidden replies, ten at a time over a 13-reply page, nested replies and their lines, closing, the fade and pop steps, the end dot's place in the action row on both platforms, the rail meeting it, and the commit's row keeping its height with its thread shut, opening, open and closing.

Watch for: the fade waits 60ms for the phone to draw the see-through frame. On a slow Android phone that may need to be longer, or the rows could appear without fading. And the replies line adds 40pt under every commit with replies, which makes the Log a little longer.

Screenshots

log (top of the Log, threads closed)

iOS light iOS dark Android light Android dark
Before
After

log-thread (before: the preview thread. After: a thread and a reply's replies open)

iOS light iOS dark Android light Android dark
Before
After

Show more at the foot of a thread, before tapping and after.

Recordings: open replies, iOS, close replies, iOS, open and close, Android, star pop, iOS, star pop, Android, pastel pop, iOS

  • No visible change

🤖 Generated with Claude Code

…ith the actions

Replies no longer show under a commit in a feed. The replies button moves
to its own line under the action row and opens the thread in place, ten
replies at a time, with Show more for the next ten. A reply has the same
button under its own actions, which opens its replies inline one step in.
Deeper than that, the button opens the reply's page.

devnull's API sends 50 replies a page whatever `limit` asks for, so the
app keeps what it was sent and shows ten at a time, asking for the next
page only once they all show.

The end dot of a commit's rail is now drawn inside its action row, so it
sits level with the actions whatever is above or below them. It used to
be placed a fixed distance from the row's bottom, which assumed the action
row's -my-[6] pulled it in. iOS does that, Android keeps the space and only
moves the drawing, and a row with a thread under it had no bottom padding,
so the dot sat above the actions in some rows and below in others. The
action row now has no vertical negative margins, and the rail's lines are
worked out from the fixed heights under it to meet the dot.

Opening and closing a thread fades its rows in and out, and the chevron
turns. Starring a commit pops the star as the web's star-pop does, and
giving a pastel bumps it as the web's pastel button does. EDGE only animates
from one frame to the next, so each step is a frame drawn when a short
background Beat comes back.

Quote now has its label beside its icon, as Reply always does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On the Log, opening or closing a commit's replies dropped or added the 7pt
under its replies line, where the hairline sits. When the commit's top was
off screen, the iPhone's list held the row below still instead, so the
commit's photo jumped by 7pt.

The row now keeps that padding, the hairline's 1pt included, with its
replies open, and only the hairline goes. The first reply takes the 7pt
off its own top, so the thread looks the same, and the elbow and the
lines beside a reply are placed from its avatar. The commit page is left
as it was: it's a scroll view, which holds its top.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant