Bots deinit - Guard against random nullptr deref on NEORules#1928
Merged
nullsystem merged 1 commit intoNeotokyoRebuild:masterfrom Apr 5, 2026
Merged
Conversation
Rare random crash, disconnecting a local server and deinitalizing, a nullptr deref can happen in: `CNEOBotVision::IsIgnored` getting ghoster player from `NEORules()`.
sunzenshen
approved these changes
Apr 5, 2026
Masterkatze
approved these changes
Apr 5, 2026
Mngdd
pushed a commit
to Mngdd/neo
that referenced
this pull request
Apr 6, 2026
…oRebuild#1928) Rare random crash, disconnecting a local server and deinitalizing, a nullptr deref can happen in: `CNEOBotVision::IsIgnored` getting ghoster player from `NEORules()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rare random crash, disconnecting a local server and deinitalizing, a nullptr deref can happen in:
CNEOBotVision::IsIgnoredgetting ghoster player fromNEORules().Toolchain
Linked Issues