Skip to content

Bots deinit - Guard against random nullptr deref on NEORules #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nullsystem merged 1 commit into from
Apr 5, 2026
Merged

Bots deinit - Guard against random nullptr deref on NEORules #1928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/game/server/neo/bot/behavior/neo_bot_grenade_throw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,11 @@ ActionResult< CNEOBot > CNEOBotGrenadeThrow::Update( CNEOBot *me, float interval
//---------------------------------------------------------------------------------------------
void CNEOBotGrenadeThrow::OnEnd( CNEOBot *me, Action< CNEOBot > *nextAction )
{
if (!NEORules()) // This can get called on de-init
{
return;
}

// Restore looking and weapon handling behaviors
me->PopRequiredWeapon();
me->StartLookingAroundForEnemies();
Expand Down
5 changes: 5 additions & 0 deletions src/game/server/neo/bot/neo_bot_vision.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ void CNEOBotVision::UpdatePotentiallyVisibleNPCVector( void )
*/
bool CNEOBotVision::IsIgnored( CBaseEntity* subject ) const
{
if (!NEORules()) // This can get called on de-init
{
return true;
}

CNEOBot* me = ( CNEOBot* )GetBot()->GetEntity();

if ( me->IsAttentionFocused() )
Expand Down
Loading