fix(rtd): strip _ref from EIDs before merging into prebid#289
Merged
Conversation
The _ref property (UID2 refresh metadata) is internal to the SDK wrapper's cache and should never leak into prebid's ortb2Fragments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mosherBT
previously approved these changes
May 21, 2026
mosherBT
reviewed
May 21, 2026
| eidsPerRoute[route] = eidsPerRoute[route] ?? { user: { ext: { eids: [] } } }; | ||
| eidsPerRoute[route].user!.ext!.eids!.push(eid); | ||
| const { _ref, ...clean } = eid as any; | ||
| eidsPerRoute[route].user!.ext!.eids!.push(clean); |
Contributor
There was a problem hiding this comment.
Should we not set eid now to clean to avoid confusion later in the code? And keep ref seperate to be referenced if we need it later.
mosherBT
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_refproperty from EIDs before pushing them into prebid'sortb2Fragments_refcontains UID2 refresh metadata (refresh tokens, expiry timestamps) used by the SDK wrapper's cache layer — it should never leak into the bid streamTest plan
_refno longer appears inreqBidsConfigObj.ortb2Fragments.global.user.ext.eidsafter RTD merge_reffrom localStorage cache, not from prebid fragments)🤖 Generated with Claude Code