Skip to content

fix(rtd): strip _ref from EIDs before merging into prebid #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosherBT merged 1 commit into from
May 21, 2026
Merged

fix(rtd): strip _ref from EIDs before merging into prebid #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/core/prebid/rtd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,8 @@ function handleRtd(

routes.forEach((route) => {
eidsPerRoute[route] = eidsPerRoute[route] ?? { user: { ext: { eids: [] } } };
eidsPerRoute[route].user!.ext!.eids!.push(eid);
const { _ref, ...clean } = eid as any;
eidsPerRoute[route].user!.ext!.eids!.push(clean);
Copy link
Copy Markdown
Contributor

@mosherBT mosherBT May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not set eid now to clean to avoid confusion later in the code? And keep ref seperate to be referenced if we need it later.

config.log("info", `EID with source ${eid.source} routed to ${route}`);
});
processedEids += 1;
Expand Down
Loading