Fix Generals Cry damage calculation with some skills#9663
Merged
LocalIdentity merged 1 commit intodevfrom Mar 16, 2026
Merged
Conversation
The dpsMultiplier was overwriting the dpsMultiplier from other skill like Lacerate so selecting double slash with lacerate and GC would not include the 2x dps multi from both slashes hitting
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
he dpsMultiplier from General Cry was overwriting the dpsMultiplier from other skills like Lacerate so selecting double slash with lacerate and GC would not include the 2x dps multi from both slashes hitting
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/upd5z0e5
Before screenshot:
After screenshot: