Repository navigation
Group item settings, add expiry report and fix notification setup feedback - #1221
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory now has one Item settings page for stock defaults and expiry reminders, plus a dedicated Expiring products report. The report remains available when reminders are off and supports product search, days ahead, status, earliest/latest expiry sorting and pagination. The bell links to the report.
Device notification setup now shows progress and actionable failure feedback, checks server registration before success, repairs missing server registrations for existing browser subscriptions, and tests only the current subscription when an endpoint is supplied. A failed delivery is no longer reported as success.
Validation: 4,106 desktop tests passed (2 skipped), 5 real MongoDB expiry tests, notification/branch regressions, production asset build, API lint (existing app warnings only), language, runtime dependency and attribution checks. Browser testing on the isolated develop site verified settings persistence, report search and sorting, expired-only filtering, report access while reminders are disabled, and visible notification failure feedback. OS-level push delivery could not be confirmed in the built-in browser; registration failure handling was verified instead.