Repository navigation
Preserve base price when adding order items - #183
Merged
Merged
Conversation
This was referenced Oct 1, 2026
sridharkalaibala
marked this pull request as ready for review
October 1, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an item through the legacy order-history search used
final_priceas its selling price. An exclusive-tax item could therefore receive tax twice when POS accepted the amendment.Submit the catalogue
priceand retainfinal_priceonly as display data. The regression executes the actual search, add and serialization functions and verifies that Rs45 is submitted rather than Rs47.25.Validation: targeted order/menu tests passed (40 tests). The full run passed 624 of 627 tests; the three dependency-only failures then passed after supplying the existing native/Playwright dependencies. Production web build, translations and syntax/diff checks passed. No native APK/device or printed receipt smoke test performed.
Companion server enforcement: Posnic/POS#1064. Keep draft for coordinated desktop/cloud rollout; not deployed.