Repository navigation
feat: add ical_value property to vUTCOffset (#876) - #2013
Open
GabrielGervasio wants to merge 11 commits into
Open
GabrielGervasio wants to merge 11 commits into
GabrielGervasio wants to merge 11 commits into
Conversation
GabrielGervasio
requested review from
angatha,
niccokunzmann and
stevepiercy
as code owners
October 22, 2026 23:36
Contributor
|
Thanks for the pull request, @GabrielGervasio! A maintainer will review it shortly. |
niccokunzmann
requested changes
Oct 23, 2026
niccokunzmann
left a comment
Member
There was a problem hiding this comment.
Thanks! Just two docs comments and then I would like to merge it.
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>
5 tasks done
7 of 31 tasks
Contributor
Author
|
Hi @niccokunzmann, I have addressed all the review suggestions and fixed the news fragment filename for Towncrier. Could you please take another look when you have a moment? Thanks! |
SemTiOne
suggested changes
Nov 20, 2026
| @@ -0,0 +1 @@ | |||
| Created the :attr:`vUTCOffset.ical_value <icalendar.prop.dt.utc_offset.vUTCOffset.ical_value>` property. @GabrielGervasio | |||
Contributor
There was a problem hiding this comment.
The correct location should be news/876.feature.1, not news/news/876.feature.1.
Suggested change
| Created the :attr:`vUTCOffset.ical_value <icalendar.prop.dt.utc_offset.vUTCOffset.ical_value>` property. @GabrielGervasio | |
| Added :attr:`~icalendar.prop.dt.utc_offset.vUTCOffset.ical_value`, which returns the UTC offset as a :class:`~datetime.timedelta`. AI was used as a reference for understanding the existing code and tests. :user:`GabrielGervasio` |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Description
This pull request implements the
ical_valueproperty for thevUTCOffsetclass as part of the polymorphism effort in #876:@property def ical_value(self) -> timedeltatovUTCOffsetinsrc/icalendar/prop/dt/utc_offset.py(according to :rfc:5545#section-3.3.14).src/icalendar/tests/prop/test_unit.pytesting positive and negative timedelta offsets.news/876.feature.AI use disclosure
AI was used only as a reference and learning tool to better understand the existing codebase functions, test suites, and project guidelines. The implementation and tests were reviewed and verified locally.
Checklist
Additional information
None.