Repository navigation
Conversation
|
Thanks for the pull request, @RajGahoi! A maintainer will review it shortly. |
Automation signalsActivity patterns show signs of automation. Evidence
Last 5 PRs: This is an automated analysis by AgentScan |
|
First thank you for the contribution. There are three other PRs for the issue:
This does also not follow the PR tempalte, why? |
|
Can you please have a look at #1803 and adapt the changes there, which you are missing? Then I suggest we proceed with this one. |
…implementation (PyCalendar#1797) - Use single_utc_property without lowercase .completed alias - Support completed parameter in Todo.new() - Update Todo class docstring doctest to assert RFC-conformant COMPLETED serialization - Register COMPLETED in test_property_docstrings UTC_PROPERTIES - Add RFC 5545 and CalDAV VTODO fixture tests
|
Thank you for pointing me to #1803 and the repository PR template, @angatha! I have updated the PR to strictly follow the PR template and adapted all missing changes from #1803:
All local tests, doctests, and ruff checks pass cleanly. Ready for your review! |
angatha
left a comment
There was a problem hiding this comment.
@niccokunzmann since you reviewed #1803, do you want to have a look?
stevepiercy
left a comment
There was a problem hiding this comment.
@RajGahoi nice work! I made a few suggestions to make links work and follow our style guide. Would you please take care? Thank you!
… fragment Signed-off-by: Raj Gahoi <gahoiraj01@gmail.com>
|
Applied all three suggestions for the docstring and news fragment. Ready for another look, @stevepiercy! |
stevepiercy
left a comment
There was a problem hiding this comment.
Documentation looks good. Thank you!
Needs a final review from @niccokunzmann or @angatha.
| @@ -0,0 +1 @@ | |||
| Added property :attr:`Todo.COMPLETED <icalendar.cal.todo.Todo.COMPLETED>` per :rfc:`5545#section-3.8.2.1`. @RajGahoi | |||
There was a problem hiding this comment.
| Added property :attr:`Todo.COMPLETED <icalendar.cal.todo.Todo.COMPLETED>` per :rfc:`5545#section-3.8.2.1`. @RajGahoi | |
| Added property :attr:`Todo.COMPLETED <icalendar.cal.todo.Todo.COMPLETED>` per :rfc:`5545#section-3.8.2.1`. :user:`RajGahoi` |
Linked issue
Description
This pull request implements the
COMPLETEDproperty forTodo(VTODO) components per RFC 5545 section 3.8.2.1, fully adapting the functionally approved implementation and review feedback from #1803 as requested by @angatha:COMPLETEDProperty: Implemented viasingle_utc_property, guaranteeing UTC timezone normalization and RFC 5545 compliance. Conforms to project conventions by exposing only the uppercase property attribute (matchingEventandAlarm).Todo.new()constructor: Addedcompleted: date | datetime | None = Nonekeyword argument with type hints and documentation.Todoclass docstring doctest to demonstratetodo.COMPLETED = ...and assert conformant serialized output (COMPLETED:20070501T120000Z).test_property_docstrings.py: AddedTodo.COMPLETEDtoUTC_PROPERTIESto verify docstring composition rules.todo_completed.ics,completed.ics, andrfc5545_completed.icsfixtures, alongside comprehensive test suite covering UTC normalization,VALUE=DATEhandling, getter/setter/deleter, constructor ergonomics, and invalid type exceptions.news/1797.feature.Checklist
Additional information
Builds upon and carries forward the work from #1803 which was functionally approved by @niccokunzmann.