Skip to content

Use block events in claude#899

Merged
LasmarKhalifa merged 1 commit into
mainfrom
05-27/use-block-events-in-claude
May 29, 2026
Merged

Use block events in claude#899
LasmarKhalifa merged 1 commit into
mainfrom
05-27/use-block-events-in-claude

Conversation

@LasmarKhalifa
Copy link
Copy Markdown
Contributor

@LasmarKhalifa LasmarKhalifa commented May 27, 2026

closes #905

Makes Claude agent cogs use block events for better multi-line formatting of prompt and response outputs.

Current formatting:
Screenshot 2026-05-29 at 10.34.36 AM.png

Formatting introduced by this change:
Screenshot 2026-05-29 at 10.33.17 AM.png

Copy link
Copy Markdown
Contributor Author

LasmarKhalifa commented May 27, 2026

Comment thread test/roast/cogs/agent/providers/claude/claude_invocation_test.rb
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch 2 times, most recently from 0568236 to fa160f5 Compare May 28, 2026 19:50
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/use-block-events-in-claude branch from e1a710b to 1785675 Compare May 28, 2026 19:50
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from fa160f5 to 82ea8c7 Compare May 28, 2026 21:11
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/use-block-events-in-claude branch from 1785675 to 1a3df53 Compare May 28, 2026 21:11
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from 82ea8c7 to f828b8d Compare May 28, 2026 21:33
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/use-block-events-in-claude branch 2 times, most recently from a6fe18c to d9aa744 Compare May 29, 2026 15:47
@LasmarKhalifa LasmarKhalifa marked this pull request as ready for review May 29, 2026 15:50
Copy link
Copy Markdown
Contributor

@dersam dersam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, didn't realize this would let us ditch a bunch of io capture in tests. Nice.

Copy link
Copy Markdown
Contributor Author

LasmarKhalifa commented May 29, 2026

Merge activity

  • May 29, 9:39 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 29, 9:41 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 29, 9:41 PM UTC: @LasmarKhalifa merged this pull request with Graphite.

@LasmarKhalifa LasmarKhalifa changed the base branch from 05-27/add-block-event-type to graphite-base/899 May 29, 2026 21:39
@LasmarKhalifa LasmarKhalifa changed the base branch from graphite-base/899 to main May 29, 2026 21:39
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/use-block-events-in-claude branch from d9aa744 to 4454c07 Compare May 29, 2026 21:40
@LasmarKhalifa LasmarKhalifa merged commit 0ac3080 into main May 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use block events in Claude agent cogs

3 participants