Skip to content

use block events for llm stats#902

Open
LasmarKhalifa wants to merge 1 commit into
mainfrom
05-28/use-block-events-for-llm-stats
Open

use block events for llm stats#902
LasmarKhalifa wants to merge 1 commit into
mainfrom
05-28/use-block-events-for-llm-stats

Conversation

@LasmarKhalifa
Copy link
Copy Markdown
Contributor

@LasmarKhalifa LasmarKhalifa commented May 28, 2026

Current LLM stats output (after "Repeat log prefix on each line of multi-line output" is merged):Screenshot 2026-05-28 at 10.45.31 AM.png

Proposed new LLM stats output:Screenshot 2026-05-28 at 10.44.26 AM.png

Copy link
Copy Markdown
Contributor Author

LasmarKhalifa commented May 28, 2026

Comment thread lib/roast/cogs/agent.rb
puts "[AGENT STATS] #{output.stats}" if config.show_stats?
puts "Session ID: #{output.session}" if config.show_stats?
if config.show_stats?
Event << { block: { header: "AGENT STATS", content: "#{output.stats}\nSession ID: #{output.session}" } }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Agent Stats" doesn't need to be in all caps here anymore, nor in square brackets. It was only like that because there wasn't a better way to make a "header" stand out before we had this new formatter. Maybe it's still better in all caps, but feel free to think about how you'd like to style the header line now that you've got cleaner block formatting

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the all caps format, because it makes it stand out from the output and for consistency with the LLM response/prompt headers. But I agree that there could be a discussion on the way we want to format headers (for all of them, including response and prompt headers). I'll mark it up as ready but if you think there could be a cleaner formatting, let me know!!

Potential candidates:

(Current for reference)

Screenshot 2026-05-29 at 5.23.25 PM.png

Screenshot 2026-05-29 at 5.24.03 PM.png

Screenshot 2026-05-29 at 5.25.38 PM.png

Screenshot 2026-05-29 at 5.28.26 PM.png

@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from 0449253 to 7ed651f Compare May 28, 2026 19:51
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch 2 times, most recently from c6d10bd to 1bf8dc5 Compare May 28, 2026 21:11
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from 7ed651f to 076d160 Compare May 28, 2026 21:11
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from 1bf8dc5 to 6053669 Compare May 28, 2026 21:33
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from 076d160 to 13658a1 Compare May 28, 2026 21:33
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from 6053669 to a080bd5 Compare May 29, 2026 15:57
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from 13658a1 to 14f98aa Compare May 29, 2026 15:57
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from a080bd5 to 55ad147 Compare May 29, 2026 20:48
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from 14f98aa to d6b84ca Compare May 29, 2026 20:48
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from 55ad147 to bfe8c0f Compare May 29, 2026 21:00
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-in-pi branch from d6b84ca to 47749f7 Compare May 29, 2026 21:00
@LasmarKhalifa LasmarKhalifa marked this pull request as ready for review May 29, 2026 21:29
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from bfe8c0f to 913f50c Compare May 29, 2026 21:34
@LasmarKhalifa LasmarKhalifa changed the base branch from 05-28/use-block-events-in-pi to graphite-base/902 May 29, 2026 21:44
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from 913f50c to 9100a12 Compare May 29, 2026 21:45
@graphite-app graphite-app Bot changed the base branch from graphite-base/902 to main May 29, 2026 21:46
@LasmarKhalifa LasmarKhalifa force-pushed the 05-28/use-block-events-for-llm-stats branch from 9100a12 to d3eb9c1 Compare May 29, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants