Repository navigation
Fix Nunavut postal-code time zones - #685
Open
JoyceMiryamH wants to merge 2 commits into
Open
JoyceMiryamH wants to merge 2 commits into
JoyceMiryamH wants to merge 2 commits into
Conversation
DominiqueFlaaa
left a comment
Contributor
There was a problem hiding this comment.
looks good, just a couple small changes
Contributor
There was a problem hiding this comment.
The siblings in this directory are named <cc>_test.rb with class <Cc>Test (pa_test.rb → PaTest, mt_test.rb → MtTest). Please rename this to ca_test.rb / CaTest. That also gives future CA tests a home.
|
|
||
| ## [Unreleased] | ||
|
|
||
| - Correct the time zones for Nunavut postal codes in Kitikmeot, Kivalliq, Resolute and Arctic Bay. |
Contributor
There was a problem hiding this comment.
please add the pr link, like the entry below
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Nunavut continues to change clocks seasonally, while Manitoba and Alberta now remain on a fixed offset. Postal codes in Nunavut therefore need local time zones instead of
America/WinnipegorAmerica/Edmonton.What approach did you choose and why?
Move Kitikmeot prefixes to
America/Cambridge_Bay, Kivalliq prefixes toAmerica/Rankin_Inlet, Resolute prefixes toAmerica/Resolute, and Arctic Bay prefixes toAmerica/Iqaluit. Canada Post's air-stage office list identifies Arctic Bay'sX0A 0A0andX0A 0B3, and Resolute'sX0A 0A2. Coral Harbour and Northwest Territories prefixes retain their existing zones.The impact of these changes
Consumers reading Canadian time-zone prefixes receive zones that reflect the local communities' clock changes.
Testing
Checklist