Repository navigation
Fix Nunavut postal-code time zones #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoyceMiryamH
wants to merge
3
commits into
Shopify:main
Choose a base branch
from
JoyceMiryamH:fix-nunavut-timezones
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−17
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require "test_helper" | ||
|
|
||
| module Worldwide | ||
| class CaTest < ActiveSupport::TestCase | ||
| test "Nunavut and neighboring postal codes have the correct timezone prefixes" do | ||
| expected_timezones = { | ||
| "X0B 0C0" => "America/Cambridge_Bay", | ||
| "X0B 1J0" => "America/Cambridge_Bay", | ||
| "X0C 0A0" => "America/Rankin_Inlet", | ||
| "X0C 0A1" => "America/Rankin_Inlet", | ||
| "X0C 0A3" => "America/Rankin_Inlet", | ||
| "X0C 0A4" => "America/Rankin_Inlet", | ||
| "X0C 0A5" => "America/Rankin_Inlet", | ||
| "X0C 0A6" => "America/Rankin_Inlet", | ||
| "X0C 0A7" => "America/Rankin_Inlet", | ||
| "X0C 0B0" => "America/Rankin_Inlet", | ||
| "X0C 0E0" => "America/Rankin_Inlet", | ||
| "X0C 0G0" => "America/Rankin_Inlet", | ||
| "X0C 0H0" => "America/Rankin_Inlet", | ||
| "X0C 0J0" => "America/Rankin_Inlet", | ||
| "X0A 0V0" => "America/Resolute", | ||
| "X0A 0A2" => "America/Resolute", | ||
| "X0A 0A0" => "America/Iqaluit", | ||
| "X0A 0B3" => "America/Iqaluit", | ||
| "X0A 0H0" => "America/Toronto", | ||
| "X0C 0A2" => "America/Atikokan", | ||
| "X0C 0C0" => "America/Atikokan", | ||
| "X0E 0A0" => "America/Edmonton", | ||
| "X0G 0A0" => "America/Edmonton", | ||
| "X1A 2N8" => "America/Edmonton", | ||
| "T5J 2R7" => "America/Edmonton", | ||
| "R3C 4T3" => "America/Winnipeg", | ||
| } | ||
|
|
||
| timezones = Worldwide.region(code: "CA").timezones | ||
| expected_timezones.each do |postal_code, timezone| | ||
| matches = timezones.select { |_name, prefixes| prefixes.any? { |prefix| postal_code.start_with?(prefix) } }.keys | ||
|
|
||
| assert_equal [timezone], matches, postal_code | ||
| end | ||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.