Skip to content

fix(plugin): ship only read-only skills/agents (1.3.1) - #30

Merged
jshorwitz merged 1 commit into
mainfrom
fix/cursor-readonly-full-trim
Nov 9, 2026
Merged

jshorwitz merged 1 commit into
mainfrom
fix/cursor-readonly-full-trim

Conversation

@jshorwitz

@jshorwitz jshorwitz commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #29 from Cursor Marketplace Bot review (Joel 8:14 AM PT GO).

Removed from skills/ (29)

ad-copy-generation, audience, bid-optimization, campaign-preflight, creative, creative-testing, google-ads-quality-score, google-shopping-optimizer, incrementality-testing, keyword-research, kill-scale-rules, launch, meta-ads-diagnostics, mmm-budget-planner, optimize, performance-max-optimizer, platform-amazon, platform-google, platform-linkedin, platform-meta, platform-microsoft, platform-openai, platform-reddit, platform-tiktok, platform-x, pre-pause-analysis, replicate, retargeting-sequence-designer, seasonal-budget-planner

Removed from agents/ (3)

budget-optimizer, creative-director, media-buyer

Kept

27 read-only skills + 3 agents (audience-builder, campaign-strategist, performance-analyst), mirrored in tools/readonly-skills.json / tools/readonly-agents.json and Claude directory allowlists.

CI

scripts/check-readonly-tools.js now fails if any non-allowlisted skill/agent ships, or if README still lists launch/write wording.

Cursor MCP URL — not switched

Probed https://mcp.synterai.com/mcp/directory:

  • Unauthenticated POST → 401 + WWW-Authenticate ✓
  • Root PRM /.well-known/oauth-protected-resource → 200 but resource is bare host
  • Path PRM /.well-known/oauth-protected-resource/mcp/directory → 401 (not PRM JSON)
  • Nested /mcp/directory/.well-known/oauth-protected-resource → 200 but resource is https://mcp.synterai.com/mcp (wrong)
  • Staging path PRM is correct (resource = .../mcp/directory)

Missing for a safe Cursor switch: prod path-PRM for /mcp/directory returning 200 with resource = https://mcp.synterai.com/mcp/directory (as on staging). Keeping .cursor-mcp.json / mcp.json on https://mcp.synterai.com until that lands (synter-media #13505 / deploy).

Test plan

  • node scripts/check-readonly-tools.js
  • node scripts/validate-manifests.js
  • python3 -m unittest scripts.test_build_packages
  • node --test scripts/*.test.js

Summary by CodeRabbit

  • Changes
    • Updated the plugin release version to 1.3.1.
    • Shifted the free listing to a read-only set of skills and agents for listing, pulling, auditing, forecasting, and reporting. Campaign changes and execution require the full product or a manual platform handoff.
    • Removed campaign-writing and launch guidance from the listing.
    • Added checks to ensure the published skills and agents match the approved read-only set.

Remove write-flavored skills (including launch/optimize) and write agents
from the repo. Rewrite README safety copy, add skill/agent allowlist CI
guards, and bump to 1.3.1. Cursor MCP URL stays on the bare host until
prod /mcp/directory path-PRM matches staging.
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The release updates plugin metadata to version 1.3.1, defines free read-only skill and agent lists, removes campaign-write guidance, and adds checks that validate the lists and related README content.

Changes: Read-only catalog and release

Layer / File(s) Summary
Define the read-only catalog
tools/readonly-*.json, README.md, skills/*/SKILL.md, agents/*.md
The allowlists and README describe the free read-only set and supported activity. The change removes campaign-planning, optimization, and execution skill and agent files.
Validate catalog consistency
scripts/check-readonly-tools.js
The checker validates the skill and agent allowlists against shipped files, checks selected README wording and links, and verifies that Claude directory allowlists match the root lists.
Update release records
.claude-plugin/plugin.json, .cursor-plugin/*, packages/claude-directory/.claude-plugin/plugin.json, plugin.json, CHANGELOG.md, scripts/test_build_packages.py
Plugin and marketplace versions change to 1.3.1. The changelog records the release, and package tests use new archive digests and an updated OpenAI skill count.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Moderate · up to 2c33d

This release narrows the plugin to read-only skills, but two retained skills still tell the assistant to apply changes, and removing public commands in a patch version may surprise users who update. Resolve the leftover write guidance and the versioning choice before merging. The checker gaps and stale README filenames are small follow-ups.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@jshorwitz
jshorwitz merged commit 8ce13fb into main Nov 9, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant