Repository navigation
Conversation
The capture check in BattlegroundWS::HandleAreaTrigger tested the capturing team's own flag with !_flagState[...], which only holds for 0. BG_WS_FlagState starts at BG_WS_FLAG_STATE_ON_BASE = 1 and nothing ever stores 0, so the flag carrier reached the flag room and no capture was ever counted. Test for BG_WS_FLAG_STATE_ON_BASE instead. Twin Peaks has the same check but numbers its states from 0, so it is not affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Fix flag captures in Warsong Gulch.
BattlegroundWS::HandleAreaTriggerlets a flag carrier capture only while his own team's flag is at its base, and tests that as!_flagState[team], which holds for 0.BG_WS_FlagStatestarts atBG_WS_FLAG_STATE_ON_BASE = 1and nothing ever stores 0, so a carrier who reaches his flag room (area triggers 3646 / 3647) never scores. The check now compares againstBG_WS_FLAG_STATE_ON_BASE.Twin Peaks has the same check, but its
BG_TP_FLAG_STATE_ON_BASEis 0, so it is not affected.Tests performed: (Does it build, tested in-game, etc)
.debug bg: "Battlegrounds are set to 1v0", so a battle starts with one player..go xyz 918 1434 346 489(the Horde flag room) and click the Horde Flag: "The Horde Flag was picked up by ...!", the carrier aura (23333) is on..go xyz 1524 1481 354 489 0(outside the Alliance flag room) and run forward into the room, through area trigger 3646..debug bgagain to switch it off.🤖 Generated with Claude Code