Skip to content

feat(models): remove constraint injector and 0.x shims for pure OOTB Zod DTOs - #95

Merged
gsmith85 merged 2 commits into
mainfrom
feat/pure-ootb-zod-dtos
Nov 18, 2026
Merged

gsmith85 merged 2 commits into
mainfrom
feat/pure-ootb-zod-dtos

Conversation

@gsmith85

@gsmith85 gsmith85 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Delete scripts/inject-schema-constraints.mjs, src/extensions.ts, and the six post-injected constraint test files (tests/injector-idempotency.test.js, tests/dependent-required.test.js, tests/profile-key-conditionals.test.js, tests/signals-property-names.test.js, tests/spec-set-constraints.test.js, and tests/spec-constraints.test.js).
  • Remove PUBLIC_ALIASES, UcpResponseSchema, and not.enum .superRefine(...) synthesis from scripts/generate-zod-from-types.mjs, and strip node.not when node.type || node.properties is truthy in prepareDefinitions() so json-schema-to-zod emits z.string() on open-union discriminator properties.
  • Update index.ts, package.json (pretest), generate_models.sh, and .github/workflows/tests.yml (model-drift installation of SHA256-verified ucp-schema v2.0.0), regenerate src/spec_generated.ts against 2026-08-25, migrate kept structural tests to canonical $defs names, and document pre-deserialization payload verification via ucp-schema validate in README.md.

Supersedes auto-closed #92 (rebased onto main after #87 merged).
Related to Universal-Commerce-Protocol/ucp#817.

@gsmith85
gsmith85 requested review from damaz91 and jingyli November 2, 2026 04:36
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Nov 2, 2026
@gsmith85
gsmith85 merged commit b405406 into main Nov 18, 2026
14 of 15 checks passed
@gsmith85
gsmith85 deleted the feat/pure-ootb-zod-dtos branch November 18, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants