Repository navigation
feat(reporting): backport SDK 17 package coverage with maintenance CI - #3735
Conversation
fd82991 to
4d823c9
Compare
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean diff, no blocking or medium findings.
Checked the package-item reporting coverage additions to the reliable reporting ledger:
- Bindings are validated against host-authorized
resolveCoverage; rows outside frozen(media_buy_id, package_id)pairs are rejected rather than normalized (assertRowsWithinFrozenPackageCoverageat producer.ts:739 guards both the revision and adjustment commit paths) — consistent with the witness-not-translator rule (no silent re-shaping/fabrication). - Reused package IDs are isolated via pair keying;
buildAdjustmentanchors deltas to the immutable prior official revision per the changeset. - Minor changeset (
.changeset/sdk-core-package-coverage.md) is correct — all new fields optional and gated onpackageBindings, so beta.5 callers are unaffected (DR-0033 backward-compat satisfied, non-mutating projection). Changeset type matches wire impact. - Dense test coverage accompanies the new branches.
No no-auto-approve team match, gated_paths false, high_risk false, no prior decision. Rows 1–8 do not fire → row 9 approve.
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean subsequent pass, no blocking findings.
This is a follow-up to a prior approve. The delta adds exact 3.3.0-beta.6 side-bundle support on the beta.5 line across four build/config files:
generate-wellknown-schemas.ts— swaps semver-dir scan forlatest(correct: well-known schemas live only in the primary cache)check-package-size.mjs— carves the beta.6 archive into its own 900 KiB cap with fail-closed fallbackpackage-size-budget.json/schemas-ensure.ts— bump ceilings and maintained versions
No shipped behavior change, changeset present (.changeset/sdk-core-package-coverage.md), and no new or lingering findings. No critical/high/medium findings reported.
Decision table: rows 1–8 do not fire (no findings, high_risk false, gated_paths false / review_decision APPROVED, no team gate). Falls through to row 9 → approve.
Why
ESA Core needs package-level reporting coverage and the exact AdCP 3.3.0-beta.6 reporting schema. Existing buyers use SDK 17 beta.22 with AdCP 3.3.0-beta.5 creative types. This PR keeps that default contract and enables CI for the new
17.x-esamaintenance branch in the same review.What changed
ADCP_VERSIONand global compatible versions remain at beta.5.17.x-esa. On this branch, CI generates registry types from the beta.22 pinned registry spec; main and 16.x still sync the live spec. These four workflow files are the complete CI change formerly proposed in ci: run checks on ESA maintenance branch #3736.The diff leaves creative and media-buy source, generated creative types,
ADCP_VERSION, and.github/workflows/release.ymlunchanged. It does not version or publish a package.Verification
6cfc7e8a1213e1b4021a1d14e30bf832fb1466fc: 41 successful checks, two expected skips, no failures or pending checks; the separate IPR status passed. This includes package artifact smoke, clean build, typecheck, unit suites, reporting storage, and both Node 20 and Node 24 reporting interop jobs.node scripts/verify-package.mjspassed. The well-known schema output stayed byte-identical to the tracked beta.5 output with beta.6 cached.Package size
The beta.6 side bundle adds 1,796 files and 25,447,134 unpacked bytes. Published beta.22 measured 25,396,564 packed bytes / 130,808,347 unpacked bytes / 8,320 files; this PR measures 29,643,629 / 156,288,746 / 10,116. SDK ceilings rise to 31,000,000 / 164,000,000 / 10,600. The 2,200,000-byte cap for other compact schema archives remains; beta.6 has a separate 900,000-byte cap and measures 832,886 bytes. Raw expanded schemas and unrelated previews remain excluded.
Release order
Merging this PR adds the SDK patch and maintenance CI to
17.x-esa. That branch's release workflow still triggers only on main and 16.x, and its Changesets prerelease tag is stillbeta, so this PR's merge does not start a maintenance publish. A release owner must review the switch toesapre-mode and a unique version before a separate reviewed change carries the maintenance release trigger andadcp-3.3-esanpm tag from #3734. A disposable Changesets preview of this head yields@adcp/sdk@17.0.0-esa.23; rerun it after merge. The generated Changesets release PR then needs human review and merge before npm publication.