Skip to content

feat(reporting): backport SDK 17 package coverage with maintenance CI - #3735

Merged
rachitm022 merged 4 commits into
17.x-esafrom
codex/esa-sdk-17-maintenance
Nov 17, 2026
Merged

rachitm022 merged 4 commits into
17.x-esafrom
codex/esa-sdk-17-maintenance

Conversation

@rachitm022

@rachitm022 rachitm022 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Why

ESA Core needs package-level reporting coverage and the exact AdCP 3.3.0-beta.6 reporting schema. Existing buyers use SDK 17 beta.22 with AdCP 3.3.0-beta.5 creative types. This PR keeps that default contract and enables CI for the new 17.x-esa maintenance branch in the same review.

What changed

  • Backport merged feat(reporting): publish trusted package coverage in Core revisions #3732's reporting runtime changes, six reporting test files, documentation generator, and reporting guide.
  • Include the signed 3.3.0-beta.6 schema and compliance bundle in clean builds and npm packages for callers that explicitly pin that version. The default ADCP_VERSION and global compatible versions remain at beta.5.
  • Add the package-coverage Changeset and adjust package-size limits for the measured beta.6 bundle.
  • Extend CI, CodeQL, reference-seller interop, and Changeset-check PR triggers to 17.x-esa. On this branch, CI generates registry types from the beta.22 pinned registry spec; main and 16.x still sync the live spec. These four workflow files are the complete CI change formerly proposed in ci: run checks on ESA maintenance branch #3736.

The diff leaves creative and media-buy source, generated creative types, ADCP_VERSION, and .github/workflows/release.yml unchanged. It does not version or publish a package.

Verification

  • Full PR CI on head 6cfc7e8a1213e1b4021a1d14e30bf832fb1466fc: 41 successful checks, two expected skips, no failures or pending checks; the separate IPR status passed. This includes package artifact smoke, clean build, typecheck, unit suites, reporting storage, and both Node 20 and Node 24 reporting interop jobs.
  • Focused reporting and version/schema tests: 358 passed, 0 failed. Local build, typecheck, formatting, boundary lint, publish-artifact checks, and packed-artifact checks passed.
  • A cache-free archive of this PR head fetched and SHA-256/cosign-verified both signed 3.3 previews. Build, publish-artifact checks, packed-artifact checks, and node scripts/verify-package.mjs passed. The well-known schema output stayed byte-identical to the tracked beta.5 output with beta.6 cached.
  • Exact-head Ladon review approved with no blocking findings.

Package size

The beta.6 side bundle adds 1,796 files and 25,447,134 unpacked bytes. Published beta.22 measured 25,396,564 packed bytes / 130,808,347 unpacked bytes / 8,320 files; this PR measures 29,643,629 / 156,288,746 / 10,116. SDK ceilings rise to 31,000,000 / 164,000,000 / 10,600. The 2,200,000-byte cap for other compact schema archives remains; beta.6 has a separate 900,000-byte cap and measures 832,886 bytes. Raw expanded schemas and unrelated previews remain excluded.

Release order

Merging this PR adds the SDK patch and maintenance CI to 17.x-esa. That branch's release workflow still triggers only on main and 16.x, and its Changesets prerelease tag is still beta, so this PR's merge does not start a maintenance publish. A release owner must review the switch to esa pre-mode and a unique version before a separate reviewed change carries the maintenance release trigger and adcp-3.3-esa npm tag from #3734. A disposable Changesets preview of this head yields @adcp/sdk@17.0.0-esa.23; rerun it after merge. The generated Changesets release PR then needs human review and merge before npm publication.

@rachitm022
rachitm022 force-pushed the codex/esa-sdk-17-maintenance branch from fd82991 to 4d823c9 Compare November 17, 2026 16:13
@rachitm022
rachitm022 marked this pull request as ready for review November 17, 2026 16:13

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean diff, no blocking or medium findings.

Checked the package-item reporting coverage additions to the reliable reporting ledger:

  • Bindings are validated against host-authorized resolveCoverage; rows outside frozen (media_buy_id, package_id) pairs are rejected rather than normalized (assertRowsWithinFrozenPackageCoverage at producer.ts:739 guards both the revision and adjustment commit paths) — consistent with the witness-not-translator rule (no silent re-shaping/fabrication).
  • Reused package IDs are isolated via pair keying; buildAdjustment anchors deltas to the immutable prior official revision per the changeset.
  • Minor changeset (.changeset/sdk-core-package-coverage.md) is correct — all new fields optional and gated on packageBindings, so beta.5 callers are unaffected (DR-0033 backward-compat satisfied, non-mutating projection). Changeset type matches wire impact.
  • Dense test coverage accompanies the new branches.

No no-auto-approve team match, gated_paths false, high_risk false, no prior decision. Rows 1–8 do not fire → row 9 approve.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean subsequent pass, no blocking findings.

This is a follow-up to a prior approve. The delta adds exact 3.3.0-beta.6 side-bundle support on the beta.5 line across four build/config files:

  • generate-wellknown-schemas.ts — swaps semver-dir scan for latest (correct: well-known schemas live only in the primary cache)
  • check-package-size.mjs — carves the beta.6 archive into its own 900 KiB cap with fail-closed fallback
  • package-size-budget.json / schemas-ensure.ts — bump ceilings and maintained versions

No shipped behavior change, changeset present (.changeset/sdk-core-package-coverage.md), and no new or lingering findings. No critical/high/medium findings reported.

Decision table: rows 1–8 do not fire (no findings, high_risk false, gated_paths false / review_decision APPROVED, no team gate). Falls through to row 9 → approve.

@rachitm022 rachitm022 changed the title feat(reporting): cover packages and bundle exact beta.6 preview feat(reporting): backport SDK 17 package coverage with maintenance CI Nov 17, 2026
@rachitm022
rachitm022 merged commit 01a4230 into 17.x-esa Nov 17, 2026
45 checks passed
@rachitm022
rachitm022 deleted the codex/esa-sdk-17-maintenance branch November 17, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant