Skip to content

ci: run checks on ESA maintenance branch - #3736

Closed
rachitm022 wants to merge 2 commits into
17.x-esafrom
codex/esa-sdk-ci-only
Closed

rachitm022 wants to merge 2 commits into
17.x-esafrom
codex/esa-sdk-ci-only

Conversation

@rachitm022

Copy link
Copy Markdown
Collaborator

Why

Draft SDK PR #3735 needs full maintenance-branch checks before the esa prerelease setup is ready. The beta.22-based 17.x-esa branch currently has no matching CI triggers.

What changed

Add 17.x-esa to the push and pull-request filters for CI, and to the pull-request filters for changeset-check, reference-seller interop and CodeQL. Treat these workflow-only edits as exempt from the package changeset check.

Safety and dependency

release.yml is byte-identical to the beta.22 tag and still triggers only on main and 16.x. Merging this PR into 17.x-esa can start CI, but cannot start a Changesets release or npm publish. After a human merges this PR, retrigger #3735's checks against the updated base and review its full results. Keep the release trigger from #3734 separate until the maintenance branch's esa pre-mode and version are reviewed.

Verification

  • npm run lint:workflows passed for all 16 workflows.
  • node --test test/ci-artifact-reuse.test.js: 6 passed, 3 skipped, 0 failed.
  • git diff --check passed. Only four workflow files changed; release.yml, ADCP_VERSION, and generated creative types are unchanged.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — workflow-only PR adding the 17.x-esa maintenance branch to CI, codeql, interop-python, and changeset-check triggers, plus extending the changeset-check exemption regex to cover those named workflow files.

Checked:

  • No src/lib/**, bin/**, scripts/**, or published-files changes — no changeset required.
  • Exemption regex stays anchored to .github/workflows/(...)\.yml$, so it only exempts the named workflow files, not library code.
  • release.yml deliberately untouched, so merging to 17.x-esa runs checks but cannot trigger a Changesets release or npm publish.
  • No wire-shape, witness/translator, transport-client, or doc-link concerns.

No findings. Not high-risk, no gated paths, no author team gate — falls through to row 9.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — CI/workflow-only change, no blocking findings.

This is a subsequent pass (prior decision: approve). The delta is a single conditional in ci.yml: on the 17.x-esa maintenance branch, generate-registry-types runs without --sync to pin the beta.22 registry spec; everywhere else keeps --sync. The condition covers both pull_request (GITHUB_BASE_REF) and push (GITHUB_REF) events, and the downstream git diff --exit-code still enforces the committed generated output.

All four changed files are CI/workflow config (changeset-check, ci, codeql, interop-python branch allowlists). No src/lib, bin, or scripts changes, so no changeset is required. No wire-shape, witness-not-translator, or version-translation concerns apply.

Decision table: no critical/high/medium findings (row 1, 4-6 N/A); gated_paths is false and review_decision is APPROVED anyway (row 2 N/A); high_risk false (rows 3, 5 N/A); prior was approve (row 6 N/A); no no-auto-approve team match (row 7 N/A); zero medium findings (row 8 N/A). Falls through to row 9 → approve.

@rachitm022

Copy link
Copy Markdown
Collaborator Author

Superseded by #3735. That PR contains these exact CI workflow commits alongside the SDK 17 reporting backport, and its full checks are green. We are reviewing and merging the combined change as one PR.

@rachitm022 rachitm022 closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant