You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Phase 3 (API) of the swc-menu-separator gen2 migration. Targets the menu-separator-migration feature branch. This branch is stacked on the Phase 2 PR (#6886), so the diff includes Phase 2 until that merges.
MenuSeparatorBase sets role="separator" in connectedCallback and exposes no properties, slots or events (B2, B5).
No size, vertical or staticColor: the base extends SpectrumElement, not DividerBase (Q2).
The migration plan checklist and decision log record Q2 and Q8 as implemented, pending reviewer confirmation.
Not done in this phase:
1st-gen @deprecated JSDoc and window.__swc.warn() for B1 to B3. The breaking-change tickets are still missing (Q4), and size can't be detected as user-set without changing SizedMixin usage, which the migration rules forbid in 1st-gen. This needs a decision before it is done.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
Nothing blocking. Two notes: (1) connectedCallback unconditionally overwrites any consumer-set role. That matches 1st-gen, which sets it in firstUpdated, but the docs should say the role is forced, not overridable (see #6891). (2) The Divider base sets the role in firstUpdated. If the timing difference is intentional (role present before a parent menu inspects its children), it's worth confirming in review, since Q8 is still marked pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Phase 3 (API) of the
swc-menu-separatorgen2 migration. Targets themenu-separator-migrationfeature branch. This branch is stacked on the Phase 2 PR (#6886), so the diff includes Phase 2 until that merges.MenuSeparatorBasesetsrole="separator"inconnectedCallbackand exposes no properties, slots or events (B2, B5).size,verticalorstaticColor: the base extendsSpectrumElement, notDividerBase(Q2).Not done in this phase:
@deprecatedJSDoc andwindow.__swc.warn()for B1 to B3. The breaking-change tickets are still missing (Q4), andsizecan't be detected as user-set without changingSizedMixinusage, which the migration rules forbid in 1st-gen. This needs a decision before it is done.Motivation and context
Locks the public contract (no public API, fixed role) before accessibility, styling and tests are added.
Related issue(s)
Screenshots (if appropriate)
N/A
Author's checklist
Validation
yarn workspace @spectrum-web-components/gen2 build: passed; compiled base contains theconnectedCallbackrole.npx eslinton the core folder: passed.npx prettier --writeon the plan and core folder: no changes needed.