Repository navigation
hack/run-e2e.sh accepts the target path after go test flags - #2226
Eric Curtin (ericcurtin) wants to merge 6 commits into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Tim Hockin (@thockin) Steven Shriver (@stshrive) PTAL when you get a chance. Thank you! |
Max Smythe (maxsmythe)
added
kind/bug
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
There was a problem hiding this comment.
Thanks for submitting a fix.
Do we really need the go regression test for the bash parser that wraps go? That feels like agent excess and it represents the bulk of the difference.
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Benjamin Elder (@BenTheElder) Dropped the Go test, only the script change is left. PTAL. |
|
Michelle Au (@msau42) Lior Lieberman (@LiorLieberman) PTAL when you get a chance, it already has one approval. Thank you! |
# Conflicts: # hack/run-e2e.sh
|
Merged main and resolved the conflicts. PTAL. |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Benjamin Elder (@BenTheElder) Haven Xia (@HavenXia) Module-qualified paths are accepted now. PTAL when you get a chance. Thank you! |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Benjamin Elder (@BenTheElder) Dmitry Berkovich (@dberkov) PTAL when you get a chance. Thank you! |
f90dd85 to
0d926c4
Compare
|
Benjamin Elder (@BenTheElder) DCO sign-off fixed, no code changes. |
Fixes #2217
The target path can now follow go test flags, so both orders in the issue run the same command.