Repository navigation
ate-setup no longer requires the GKE PodMonitoring CRD - #2604
Eric Curtin (ericcurtin) wants to merge 6 commits into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Zoe Zhao (@zoez7) Haven Xia (@HavenXia) PTAL when you get a chance. Thank you! |
|
Steven Shriver (@stshrive) Do you have time to review this one? Thanks a lot! |
…dmonitoring # Conflicts: # cmd/ate-setup/internal/steps/deploy_test.go
|
Merged main and resolved the conflicts. PTAL. |
Steven Shriver (stshrive)
left a comment
Steven Shriver (stshrive)
left a comment
There was a problem hiding this comment.
You can verify if this is correct or not: I feel like this is a step in removing GKE from the hot path but does not completely remove it from the tree. This is fine as a quick fix I just have one request that you add a comment clarifying this in the code itself.
Bowei Du (bowei)
added
area/dev-infra
area/network
area/observability
kind/bug
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Merged main again and resolved the conflicts. PTAL when you get a chance. Thank you! |
|
Approved by two reviewers. Michelle Au (@msau42) Max Smythe (@maxsmythe) PTAL when you get a chance. Thank you! |
|
FYI according to https://groups.google.com/g/ate-dev/c/vFELtvQLJ5g you need special approval for such change to merge now. |
|
Haven Xia (@HavenXia) Thank you for the heads up, I will wait for a maintainer decision. |
Head branch was pushed to by a user without write access
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Tim Hockin (@thockin) Benjamin Elder (@BenTheElder) PTAL when you get a chance. Thank you! |
56fa189 to
e09d576
Compare
|
Haven Xia (@HavenXia) DCO sign-off fixed, no code changes. |
Fixes #2589
The router PodMonitoring is applied on its own and skipped when the cluster has no such CRD.