Repository navigation
feat(pagination): add server-side pagination and label filters (RHOAIENG-98858) - #122
Merged
Gkrumbach07 merged 2 commits intoOct 22, 2026
Merged
Conversation
danreed-rh
force-pushed
the
98858/server-side-pagination-type-label-filter
branch
2 times, most recently
from
October 19, 2026 15:32
58f352f to
16e8445
Compare
Contributor
|
Nice — pagination is genuinely server-side and stays relay-only (forwards the SDK
No rush on timing — this is tracked for 3.7 (RHOAIENG-98858), so it doesn't need to beat the 3.6 freeze. |
danreed-rh
force-pushed
the
98858/server-side-pagination-type-label-filter
branch
from
October 22, 2026 15:53
0d99e32 to
7aafa70
Compare
Signed-off-by: Daniel Reed <dareed@redhat.com>
#124 added a second NewSandboxService parameter (SandboxRawExec). The pagination tests still made the one-argument call, so the handlers test package stopped compiling after the rebase onto main. Pass nil, as the other handler tests do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gkrumbach07
force-pushed
the
98858/server-side-pagination-type-label-filter
branch
from
October 22, 2026 22:25
7aafa70 to
5b95b7f
Compare
Contributor
|
Heads-up: I rebased this branch onto
Before you push again, reset your local branch: |
This was referenced Oct 22, 2026
Gkrumbach07
added a commit
that referenced
this pull request
Oct 22, 2026
Since server-side pagination (#122) the sandbox list has a third filter and a pager above it, and at CI's 1280x720 viewport its second row starts below the fold of the page's scrolling content area. Cypress counts a row its scroll container clips as not visible, so "displays sandbox list with different phases" failed on main's push runs for 61e2590 and 70afb39 ("its content is being clipped by one of its parent elements, which has a CSS property of overflow"). Each row is now scrolled to before it is checked. The workspace draft-summary stub also matched only a bare path, while the paged list asks with ?sandbox=..., so those requests fell through to a BFF that is not running and answered 500. The stub now matches with a query. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageSizeis absent; paged requests returnitemsandnextPageToken.Ticket: RHOAIENG-98858
The ticket describes
limitandoffset, but the pinned OpenShell Go SDK exposesPageSizeand opaquePageTokeninListOptions. This PR uses that upstream cursor contract rather than inventing an offset layer.Verification
go test ./...: passedgit diff --check: passedThe local gateway compatibility suite was not run because the Docker daemon is unavailable in this environment. CI should verify the real gateway contract. The
make linttarget reached its Go lint step, butgolangci-lintis not installed locally;go vet ./...passed.