Repository navigation
build(backend): bump golangci-lint to v2.14.0 - #9210
Merged
Merged
Conversation
- golangci-lint v2.12.2 -> v2.14.0 in backend/Makefile and the golangci-lint workflow - staticcheck v0.8.1 reports the aws-sdk-go v1 SA1019 message without quotes; let the kiro exclusion match both forms - staticcheck v0.8.1 newly reports 201 uses of the deprecated RawDataSubTaskArgs.Params across ~40 plugins. Exclude that single message centrally: switching to Options changes the stored _raw_data_params and needs a per-plugin data migration - fix two go vet findings in tests (unused fmt.Sprintf result, unkeyed CommitUrlPattern literals) Signed-off-by: DoDiODev <DoDiDev@proton.me>
klesh
approved these changes
Oct 14, 2026
klesh
left a comment
klesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for your contribution.
DoDiODev
added a commit
to DoDiODev/devlake
that referenced
this pull request
Oct 14, 2026
…v2.14.0 (apache#9208, apache#9210) Signed-off-by: DoDiODev <DoDiDev@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump golangci-lint from v2.12.2 to v2.14.0 and adjust the configuration to the newer staticcheck (v0.8.1) it ships.
Changes
backend/Makefile(go-dep),.github/workflows/golangci-lint.ymlv2.12.2→v2.14.0backend/.golangci.yamlSA1019forgithub.com/aws/aws-sdk-go/...without quotes, so the rule from #9197 now matches both formsbackend/.golangci.yamlSA1019: …RawDataSubTaskArgs).Params is deprecated(see below)plugins/github/tasks/cicd_job_convertor_test.gofmt.Sprintfresult in a benchmark helperplugins/jira/e2e/issue_repo_commit_test.goCommitUrlPatternliteralsWhy exclude
RawDataSubTaskArgs.Paramsstaticcheck v0.8.1 newly reports 201 uses of the deprecated
RawDataSubTaskArgs.Paramsfield across about 40 plugins. The field is JSON-encoded into_raw_data_paramsof every raw table and used to find existing raw data. Switching a plugin toOptionschanges that value, so existing raw data would no longer be matched until it is collected again. That is a per-plugin decision, not something to do mechanically in a linter bump.The new rule only matches this one message, so other
SA1019findings are still reported. It can be removed once the plugins have moved toOptions.Verification
golangci-lint config verify(v2.14.0)backend/, without issue limitsgo vetand test compilation of the two changed test packages