Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v9
with:
version: v2.12.2
version: v2.14.0
working-directory: ./backend
10 changes: 9 additions & 1 deletion backend/.golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,15 @@ linters:
- linters:
- staticcheck
path: plugins/kiro/
text: 'SA1019: "github.com/aws/aws-sdk-go/'
text: 'SA1019: "?github.com/aws/aws-sdk-go/'
# RawDataSubTaskArgs.Params is deprecated in favour of Options, but it is
# JSON-encoded into _raw_data_params of every raw table. Migrating a
# plugin changes that key and orphans existing raw data, so this needs a
# per-plugin migration rather than a mechanical rewrite. Reported since
# golangci-lint v2.14.0 (staticcheck v0.8.1).
- linters:
- staticcheck
text: 'SA1019: .*RawDataSubTaskArgs\)\.Params is deprecated'
paths:
- third_party$
- builtin$
Expand Down
2 changes: 1 addition & 1 deletion backend/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ all: build
go-dep:
go install github.com/vektra/mockery/v3@$(MOCKERY_VERSION)
go install github.com/swaggo/swag/cmd/swag@v1.16.6
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2
go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.14.0

go-dev-tools:
# go install github.com/atombender/go-jsonschema/cmd/gojsonschema@latest
Expand Down
2 changes: 1 addition & 1 deletion backend/plugins/github/tasks/cicd_job_convertor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func GenJobID() {
connectionId := uint64(1)
runId := 1
lineId := 1
fmt.Sprintf("GithubJob:%d:%d:%d", connectionId, runId, lineId)
_ = fmt.Sprintf("GithubJob:%d:%d:%d", connectionId, runId, lineId)
}

func BenchmarkGenJobIDWithReflect(b *testing.B) {
Expand Down
6 changes: 3 additions & 3 deletions backend/plugins/jira/e2e/issue_repo_commit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ func TestConvertIssueRepoCommitsDataFlow(t *testing.T) {
ScopeConfig: &models.JiraScopeConfig{
RemotelinkCommitShaPattern: `.*/commit/(.*)`,
RemotelinkRepoPattern: []models.CommitUrlPattern{
{"", `https://bitbucket.org/(?P<namespace>[^/]+)/(?P<repo_name>[^/]+)/commits/(?P<commit_sha>\w{40})`},
{"", `https://gitlab.com/(?P<namespace>\S+)/(?P<repo_name>\S+)/-/commit/(?P<commit_sha>\w{40})`},
{"", `https://github.com/(?P<namespace>[^/]+)/(?P<repo_name>[^/]+)/commit/(?P<commit_sha>\w{40})`},
{Pattern: "", Regex: `https://bitbucket.org/(?P<namespace>[^/]+)/(?P<repo_name>[^/]+)/commits/(?P<commit_sha>\w{40})`},
{Pattern: "", Regex: `https://gitlab.com/(?P<namespace>\S+)/(?P<repo_name>\S+)/-/commit/(?P<commit_sha>\w{40})`},
{Pattern: "", Regex: `https://github.com/(?P<namespace>[^/]+)/(?P<repo_name>[^/]+)/commit/(?P<commit_sha>\w{40})`},
},
},
},
Expand Down
Loading