You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(core-spec): add CLICKHOUSE to Dialect enum (#546) - #558
Adds CLICKHOUSE to the Dialect enum across core-spec/spec.md, core-spec/ossie-schema.json, and core-spec/spec.yaml. This officially registers ClickHouse as a supported expression language dialect in the Apache Ossie specification, allowing semantic models targeting ClickHouse SQL expressions to pass core schema validation.
Two of the checks that run on a core-spec/** change fail on this branch as it stands.
python-ci runs test_dialect_enum_matches_core_schema in python/tests/test_models.py, which asserts that OssieDialect in python/src/ossie/models.py has the same members as the schema enum, so CLICKHOUSE needs a line there too. The same test runs again in validation-ci's shared Python model tests.
validation-ci's spec.yaml sync step runs scripts/generate-spec-types.py --check, and that stops with no description for 'dialects' value 'CLICKHOUSE' until the dialects descriptions map in SECTIONS gets an entry. The script renders that block from the map and diffs it against spec.yaml, so with "CLICKHOUSE": "ClickHouse SQL" the line you already added matches what it writes.
#538 added HOLISTICS_AQL across the same five files, if you want a diff to follow.
Thanks @kayemkim for your support
I updated models.py and scripts/generate-spec-types.py with CLICKHOUSE.
CI checks are re-running now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CLICKHOUSEto theDialectenum acrosscore-spec/spec.md,core-spec/ossie-schema.json, andcore-spec/spec.yaml. This officially registers ClickHouse as a supported expression language dialect in the Apache Ossie specification, allowing semantic models targeting ClickHouse SQL expressions to pass core schema validation.Related Issues
Refers to #546
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changes.github/labeler.ymlis updated with the new pathValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance
NOTICEand/orLICENSEhave been updated per ASF policy