Skip to content

feat(core-spec): add CLICKHOUSE to Dialect enum (#546) - #558

Open
MahmoudHassanen99 wants to merge 3 commits into
apache:mainfrom
MahmoudHassanen99:feat/spec-add-clickhouse-dialect
Open

MahmoudHassanen99 wants to merge 3 commits into
apache:mainfrom
MahmoudHassanen99:feat/spec-add-clickhouse-dialect

Conversation

@MahmoudHassanen99

Copy link
Copy Markdown

Summary

Adds CLICKHOUSE to the Dialect enum across core-spec/spec.md, core-spec/ossie-schema.json, and core-spec/spec.yaml. This officially registers ClickHouse as a supported expression language dialect in the Apache Ossie specification, allowing semantic models targeting ClickHouse SQL expressions to pass core schema validation.

Related Issues

Refers to #546

Checklist

Specification

  • Spec changes are included in core-spec/ and follow the existing structure
  • Spec changes have been discussed on the mailing list or in a linked issue
  • Breaking changes to the spec are clearly called out in the summary

Ontology

  • Ontology changes in ontology/ are consistent with spec changes
  • New or modified terms are defined and documented

Converters

  • Converter logic in converters/ is updated to reflect spec or ontology changes
  • New converters include tests under the converter's test directory
  • If adding a new converter, .github/labeler.yml is updated with the new path

Validation

  • Validation rules in validation/ are updated if the spec changed
  • New validation cases are covered by tests

Documentation

  • docs/ is updated to reflect any user-facing changes
  • New features or behaviors are documented with examples where appropriate
  • CONTRIBUTING.md is updated if the contribution process changed

Examples

  • examples/ are added or updated for any new spec constructs or converter support

Tests

  • All existing tests pass (pytest / CI green)
  • New functionality is covered by tests

Compliance

  • ASF license headers are present on all new source files
  • No third-party dependencies are added without PMC/IPMC approval
  • If third-party source code is vendored/copied (not just declared as a dependency), NOTICE and/or LICENSE have been updated per ASF policy

@github-actions github-actions Bot added the spec label Oct 10, 2026
@kayemkim

Copy link
Copy Markdown
Contributor

Two of the checks that run on a core-spec/** change fail on this branch as it stands.

python-ci runs test_dialect_enum_matches_core_schema in python/tests/test_models.py, which asserts that OssieDialect in python/src/ossie/models.py has the same members as the schema enum, so CLICKHOUSE needs a line there too. The same test runs again in validation-ci's shared Python model tests.

validation-ci's spec.yaml sync step runs scripts/generate-spec-types.py --check, and that stops with no description for 'dialects' value 'CLICKHOUSE' until the dialects descriptions map in SECTIONS gets an entry. The script renders that block from the map and diffs it against spec.yaml, so with "CLICKHOUSE": "ClickHouse SQL" the line you already added matches what it writes.

#538 added HOLISTICS_AQL across the same five files, if you want a diff to follow.

@MahmoudHassanen99

MahmoudHassanen99 commented Oct 12, 2026 •

Copy link
Copy Markdown
Author

Thanks @kayemkim for your support
I updated models.py and scripts/generate-spec-types.py with CLICKHOUSE.
CI checks are re-running now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants