Skip to content

feat(core-spec): add CLICKHOUSE to Dialect enum (#546) #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MahmoudHassanen99 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(core-spec): add CLICKHOUSE to Dialect enum (#546) #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8936af4
feat(core-spec): add CLICKHOUSE to Dialect enum (#546)
MahmoudHassanen99 Oct 10, 2026
e311aef
Add CLICKHOUSE data type to OssieDataSource enum
MahmoudHassanen99 Oct 12, 2026
1b376c5
Add ClickHouse SQL to supported datatypes
MahmoudHassanen99 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-spec/ossie-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"$defs": {
"Dialect": {
"type": "string",
"enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "HOLISTICS_AQL", "OSSIE_SQL_2026"],
"enum": ["ANSI_SQL", "SNOWFLAKE", "MDX", "TABLEAU", "DATABRICKS", "MAQL", "BIGQUERY", "SIGMA", "THOUGHTSPOT", "DAX", "HOLISTICS_AQL", "OSSIE_SQL_2026", "CLICKHOUSE"],
"description": "Supported SQL and expression language dialects"
},
"Vendor": {
Expand Down
1 change: 1 addition & 0 deletions core-spec/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ Dialects in which metric and field expressions can be declared.
| `DAX` | Data Analysis Expressions (Power BI / Analysis Services) |
| `HOLISTICS_AQL` | Holistics AQL (Analytical Query Language) |
| `OSSIE_SQL_2026` | Ossie's portable SQL expression language, defined in `expression_language.md` |
| `CLICKHOUSE` | ClickHouse SQL |

`OSSIE_SQL_2026` is the only dialect whose semantics this specification defines. The other values
identify vendor or third-party expression languages. Ossie treats expressions in those dialects as
Expand Down
1 change: 1 addition & 0 deletions core-spec/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ dialects:
- "DAX" # Data Analysis Expressions (Power BI / Analysis Services)
- "HOLISTICS_AQL" # Holistics AQL (Analytical Query Language)
- "OSSIE_SQL_2026" # Ossie portable SQL expression language (see expression_language.md)
- "CLICKHOUSE" # ClickHouse SQL

# Supported logical data types for fields and metrics
# Auto-generated from ossie-schema.json ($defs.DataType.enum).
Expand Down
1 change: 1 addition & 0 deletions python/src/ossie/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ class OssieDialect(str, Enum):
DAX = "DAX"
HOLISTICS_AQL = "HOLISTICS_AQL"
OSSIE_SQL_2026 = "OSSIE_SQL_2026"
CLICKHOUSE = "CLICKHOUSE"


class OssieDataType(str, Enum):
Expand Down
1 change: 1 addition & 0 deletions scripts/generate-spec-types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"DAX": "Data Analysis Expressions (Power BI / Analysis Services)",
"HOLISTICS_AQL": "Holistics AQL (Analytical Query Language)",
"OSSIE_SQL_2026": "Ossie portable SQL expression language (see expression_language.md)",
"CLICKHOUSE": "ClickHouse SQL",
},
},
{
Expand Down
Loading