Skip to content

fix(query-redis-labs): read the Redis port from REDIS_PORT - #498

Merged
HarshMN2345 merged 1 commit into
mainfrom
fix-redis-labs-port
Nov 9, 2026
Merged

HarshMN2345 merged 1 commit into
mainfrom
fix-redis-labs-port

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

Fixes #490.

The client hardcoded port 14714, but Redis Cloud gives each database its own port. It now reads REDIS_PORT, falling back to 14714 so existing functions keep working. Documented in the README.

Tested against a local Redis on port 16380: connects and reads/writes with REDIS_PORT=16380; without it, it still dials 14714.

@appwrite

appwrite Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The port override and unset-variable fallback match the intended behavior, with no concrete defects found.

The Redis Labs function now reads its connection port from REDIS_PORT, defaulting to 14714 when the variable is unset. The README documents the optional environment variable and shows a sample port.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 2
File Change
node/query-redis-labs/src/redis.js Uses the configured Redis port when present and preserves the existing default otherwise.
node/query-redis-labs/README.md Documents REDIS_PORT as an optional environment variable.

Reviewed c7695f5 · Details · Comment @appwrite review to re-run, or mention @appwrite with a question.

@appwrite appwrite Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@HarshMN2345
HarshMN2345 merged commit 740b276 into main Nov 9, 2026
27 of 28 checks passed
adityaoberai added a commit to appwrite/appwrite that referenced this pull request Nov 9, 2026
Stripe, Autodesk and Box sign-in, and the Pinecone, LangChain RAG,
Replicate and Redis Cloud templates were held back from the catalog because
they didn't work as released. Their fixes are merged (#15414, #15416,
#15417, #15421 and appwrite/templates#498), so add their pages:

- Autodesk is new. The others come from the held-back drafts, without the
  workarounds for the template variable names and the hardcoded Redis port.
- The template pages say what Any execute access exposes and how to narrow
  it, like the other template pages.
- The pages list Cloud only, because no self-hosted release includes the
  fixes yet.

Each page gets a cover in the catalog style. Etsy sign-in and the GitHub
issue bot template still don't work, so they stay out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: query-redis-labs hardcodes Redis port 14714

1 participant