Repository navigation
fix(discord-command-bot): make the Python setup script run and send JSON - #499
Merged
Merged
Conversation
🟢 Tier S · Ready to mergeThe Python Discord command setup now imports its utility using the script execution path and submits the registration payload as JSON. This matches the documented
📂 Walkthrough · 1
Reviewed |
Draft
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Python part of #491.
setup.pyruns as a script (python src/setup.py), so the relativefrom .utilsimport failed and the build broke. It now importsutilsdirectly, which resolves because the script's directory is on the path.json=.Tested by running
python src/setup.pywith the template's requirements: before,ImportError: attempted relative import; after, it posts{"name": "hello", ...}as JSON to Discord (401 with a dummy token, as expected).The Go variant's missing registration step is not covered here.