Repository navigation
Detect failed legacy plugin conversions on Bukkit - #189
Merged
Merged
Conversation
JulianVennen
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CraftBukkit could not convert a class of a legacy plugin (no
api-versionin its plugin.yml), nothing was detected.This PR adds a problem for it that names the plugin and suggests installing a different version or removing it.
The problem lives in Bukkit, because the message comes from
CraftMagicNumbersin CraftBukkit, so Paper and Folia inherit it.The log contains the full name of the plugin (
Name v1.0), so the pattern only captures the name beforev.It extends
PluginProblemto reusePluginInstallDifferentVersionSolutionandPluginRemoveSolution, and it is reported once per plugin even if several classes fail.The warning
Legacy plugin ... does not specify an api-version.is not covered here.Changes
LegacyPluginConversionProblemand register it inBukkitAnalyserlegacy-plugin-conversion-problemtranslationpaper-legacy-plugin-conversion-26-3.logfixture