Repository navigation
Require the log prefix for Bukkit version line detection - #191
Merged
Merged
Conversation
JulianVennen
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bukkit servers are detected by their startup line, built as
PREFIX This server is running <logIdentifier>.Paper, Purpur and Folia added a second identifier with a top-level
|, which turned the pattern into two alternatives:The second alternative has no prefix, so
This server is running Paper versionanywhere in a log was enough to detect it as Paper.Current versions (
Paper version 1.21.1-116-master@e7e1ab5) were only detected through that alternative.This PR replaces the
$logIdentifierstring with a$logIdentifiersarray and creates one prefixed detector per identifier.Paper, Purpur and Folia now list the old
CraftBukkit version git-...name and their own... versionname as separate entries.This depends on #: Paper 26.3 console logs only keep their detection because the prefix now matches
[16:24:27 INFO]:.No expected output changed, all test logs are detected as before.
There is no test log for an unprefixed version line, because none of the real logs has one.
Changes
$logIdentifierwith$logIdentifiersand create one prefixed detector per entry