Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerJarInPluginFolderProblemcould start the path at any non-space character and then searched up to the next colon or line end.On a long line without a colon this is quadratic: 94 ms on 20 KB and 1.4 s on 80 KB, minutes for a long mod list.
Paper always writes the path after ": " ("Error loading plugin: plugins/server.jar appears to be ..." and in the exception message), so this PR starts it there with
(?<=: ).Relative paths, absolute paths, Windows paths and paths with spaces match as before; on 80 KB it now takes 0.1 ms.
Changes
ServerJarInPluginFolderProblemand add an exampleKNOWN_UNSAFE_PATTERNS