Skip to content

Start path for server jar only after a colon #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavog merged 3 commits into from
Nov 13, 2026
+4 −3
Merged

Start path for server jar only after a colon #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8eb493
start server jar path only after a colon
pavog Nov 13, 2026
c6b03ee
Merge remote-tracking branch 'origin/master' into server-jar-pattern-…
pavog Nov 13, 2026
c17cc34
remove server jar pattern from known unsafe patterns again
pavog Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Analysis/Problem/Paper/ServerJarInPluginFolderProblem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,16 @@ public function getMessage(): string
}

/**
* Example: "Error loading plugin: plugins/server.jar appears to be a server jar! Server jars do not belong in the plugin folder."
*
* @inheritDoc
*/
public static function getPatterns(): array
{
return [
// the path is either relative (plugins/server.jar) or absolute (/srv/plugins/server.jar, C:\server\plugins\server.jar)
'/((?:[a-zA-Z]:)?[^\s:][^\n:]*?\.jar) appears to be a server jar! Server jars do not belong in the plugin folder\./'
// it always follows ": ", starting it anywhere else makes the pattern scan the rest of the line from every position
'/(?<=: )((?:[a-zA-Z]:)?[^\s:][^\n:]*?\.jar) appears to be a server jar! Server jars do not belong in the plugin folder\./'
];
}

Expand Down
2 changes: 0 additions & 2 deletions test/tests/Performance/PatternSafetyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
use Aternos\Codex\Analysis\PatternInsightInterface;
use Aternos\Codex\Minecraft\Analysis\Problem\Bukkit\ChunkLoadExceptionProblem;
use Aternos\Codex\Minecraft\Analysis\Problem\Forge\ModDependencyProblem;
use Aternos\Codex\Minecraft\Analysis\Problem\Paper\ServerJarInPluginFolderProblem;
use Aternos\Codex\Minecraft\Test\Logs\TestLog;
use FilesystemIterator;
use Generator;
Expand Down Expand Up @@ -76,7 +75,6 @@ class PatternSafetyTest extends TestCase
protected const array KNOWN_UNSAFE_PATTERNS = [
ChunkLoadExceptionProblem::class => [0, 1, 2],
ModDependencyProblem::class => ["loading-failed-exception"],
ServerJarInPluginFolderProblem::class => [0],
];

/**
Expand Down
Loading