fix: prevent Learn More from suppressing sunset toast and fix popup clipping#549
Merged
ashishrp-aws merged 4 commits intoaws:mainfrom Apr 29, 2026
Merged
Conversation
Add upload-artifact steps to the Maven build workflow so the plugin JAR and p2 update site ZIP are downloadable from the Actions tab on every PR and main push. Retained for 30 days.
…and fix popup clipping - Learn More now opens the URL and closes the popup without persisting the dismissed key, so the notification reappears on next launch - Only the explicit Dismiss button suppresses future appearances - Fix notification popup height calculation to use width-constrained computeSize so wrapped text and button row are not clipped
- Learn More now only opens the URL without closing the popup - Users can click Learn More, read the page, then come back and Dismiss
laileni-aws
approved these changes
Apr 29, 2026
Will-ShaoHua
changed the title
ashishrp-aws
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for thesunset notification toast (PR #545):
Learn More no longer suppresses future notifications — clicking "Learn More" previously called
dismiss()which persisted thekiroSunsetNotificationDismissedkey. Now it only opens the URL. The notification will reappear on next Eclipse launch until the user explicitly clicks "Dismiss".Fix notification popup height clipping — the button row (Learn More / Dismiss) was cut off because
initializeBounds()computed height with unconstrained width (computeSize(SWT.DEFAULT, SWT.DEFAULT)). Since the popup is capped atMAX_WIDTH=400, text wraps and the actual height is taller than the unconstrained estimate. Now computes height with the constrained width so the layout engine accounts for wrapping + buttons.Testing