Skip to content

fix: prevent Learn More from suppressing sunset toast and fix popup clipping #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishrp-aws merged 4 commits into from
Apr 29, 2026
Merged

fix: prevent Learn More from suppressing sunset toast and fix popup clipping #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68467fb
ci: upload plugin JAR and update site as build artifacts
Will-ShaoHua Apr 28, 2026
99ddddd
Merge remote-tracking branch 'upstream/main' into feat/ci-artifact-up…
Will-ShaoHua Apr 28, 2026
92ecc2c
fix(notifications): prevent Learn More from suppressing sunset toast …
Will-ShaoHua Apr 29, 2026
d301cc8
Merge upstream/main and keep Learn More popup open
Will-ShaoHua Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plugin/src/software/aws/toolkits/eclipse/amazonq/util/KiroSunsetNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ protected void createContentArea(final Composite parent) {
@Override
public void widgetSelected(final SelectionEvent e) {
PluginUtils.openWebpage(Constants.KIRO_SUNSET_LEARN_MORE_URL);
dismiss();
}
});

Expand Down
6 changes: 3 additions & 3 deletions plugin/src/software/aws/toolkits/eclipse/amazonq/util/ToolkitNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ protected final String getPopupShellTitle() {
@Override
protected final void initializeBounds() {
Rectangle clArea = getPrimaryClientArea();
Point initialSize = getShell().computeSize(SWT.DEFAULT, SWT.DEFAULT);
int height = Math.max(initialSize.y, MIN_HEIGHT);
int width = Math.min(initialSize.x, MAX_WIDTH);
int width = Math.min(getShell().computeSize(SWT.DEFAULT, SWT.DEFAULT).x, MAX_WIDTH);
// Recompute height with the constrained width so wrapped text and buttons are accounted for
int height = Math.max(getShell().computeSize(width, SWT.DEFAULT).y, MIN_HEIGHT);
Point size = new Point(width, height);
// Calculate the position for the new notification
int x = clArea.x + clArea.width - size.x - PADDING_EDGE;
Expand Down
Loading