Skip to content

feat(native-codegen): decode enum values and union arms a client doesn't know - #1481

Merged
ekjotmultani merged 34 commits into
mainfrom
feat/native-codegen-unknown-enum-values
Nov 19, 2026
Merged

ekjotmultani merged 34 commits into
mainfrom
feat/native-codegen-unknown-enum-values

Conversation

@ekjotmultani

@ekjotmultani ekjotmultani commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Native codegen decodes enum values and string-discriminated union arms a client does not know into an unknown case that keeps the raw value, instead of failing to decode. Dart, Swift and Kotlin, with fixture 45.

@changeset-bot

changeset-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 26dc206

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ekjotmultani
ekjotmultani force-pushed the feat/native-codegen-unknown-enum-values branch from e8ff32e to 1ccb7ef Compare November 13, 2026 07:08
@ekjotmultani
ekjotmultani force-pushed the feat/native-codegen-unknown-enum-values branch from 1ccb7ef to ba71363 Compare November 13, 2026 23:34
@ekjotmultani
ekjotmultani marked this pull request as ready for review November 17, 2026 08:53
@ekjotmultani
ekjotmultani requested a review from a team as a code owner November 17, 2026 08:53

@mattcreaser mattcreaser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's strip the comments added to generated code, they don't add anything of value

@ekjotmultani

Copy link
Copy Markdown
Contributor Author

Done in 52e12f5: the generators no longer emit the comments this PR added (Dart, Swift and Kotlin), and the goldens are regenerated. Comments that main already generated (file headers, entry-point docs, the existing union serializer KDoc) are unchanged. 41a7981 also moves the Dart CHANGELOG entries under ## Unreleased, so the published 0.2.0 notes match main.

thisisabhash
thisisabhash previously approved these changes Nov 19, 2026

This branch was previously deployed

1 inactive deployment
e2e — f7ea9dbf Deployed Nov 19, 2026 by ekjotmultani via Swift E2E (sandbox) #7292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants